Issue 10913081: Fix resolution of type parameters in static context, and the use of type parameters in closures.

Issue 10913081: Fix resolution of type parameters in static context, and the use of type parameters in closures. (Closed)

Created:
8 years, 3 months ago by ngeoffray

Modified:
8 years, 3 months ago

Reviewers:
karlklose, floitsch

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix resolution of type parameters in static context, and the use of type parameters in closures. Committed: https://code.google.com/p/dart/source/detail?r=11881

Patch Set 2 : #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+164 lines, -50 lines)			Patch
M	lib/compiler/implementation/closure.dart	View	1	6 chunks	+45 lines, -33 lines	0 comments	Download
M	lib/compiler/implementation/elements/elements.dart	View		3 chunks	+23 lines, -3 lines	0 comments	Download
M	lib/compiler/implementation/resolver.dart	View	1	6 chunks	+27 lines, -10 lines	0 comments	Download
M	lib/compiler/implementation/ssa/builder.dart	View		1 chunk	+8 lines, -3 lines	0 comments	Download
M	tests/language/language.status	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
A	tests/language/type_parameter_test.dart	View		1 chunk	+50 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM, but wait for Karl to have a look at the resolver changes. https://chromiumcodereview.appspot.com/10913081/diff/5001/lib/compiler/implementation/closure.dart File ...

8 years, 3 months ago (2012-09-05 13:50:34 UTC) #2

karlklose

LGTM. https://chromiumcodereview.appspot.com/10913081/diff/5001/lib/compiler/implementation/resolver.dart File lib/compiler/implementation/resolver.dart (right): https://chromiumcodereview.appspot.com/10913081/diff/5001/lib/compiler/implementation/resolver.dart#newcode2662 lib/compiler/implementation/resolver.dart:2662: result = super.lookup(name); Perhaps add a comment here ...

8 years, 3 months ago (2012-09-05 13:58:36 UTC) #3

ngeoffray

8 years, 3 months ago (2012-09-05 15:36:11 UTC) #4

Thanks Karl and Florian.

https://chromiumcodereview.appspot.com/10913081/diff/5001/lib/compiler/implem...
File lib/compiler/implementation/closure.dart (right):

https://chromiumcodereview.appspot.com/10913081/diff/5001/lib/compiler/implem...
lib/compiler/implementation/closure.dart:257: if (insideClosure &&
On 2012/09/05 13:50:34, floitsch wrote:
> As discussed: explain that this is not just an optimization.

Done.

https://chromiumcodereview.appspot.com/10913081/diff/5001/lib/compiler/implem...
lib/compiler/implementation/closure.dart:500: // TODO(floitsch): currently all
variables are considered to be
On 2012/09/05 13:50:34, floitsch wrote:
> Remove the TODO.

Done.

https://chromiumcodereview.appspot.com/10913081/diff/5001/lib/compiler/implem...
File lib/compiler/implementation/resolver.dart (right):

https://chromiumcodereview.appspot.com/10913081/diff/5001/lib/compiler/implem...
lib/compiler/implementation/resolver.dart:2662: result = super.lookup(name);
On 2012/09/05 13:58:36, karlklose wrote:
> Perhaps add a comment here that this means going to the TypeDeclaration scope,
> which contains the type variables of the class.

Done.

https://chromiumcodereview.appspot.com/10913081/diff/5001/tests/language/lang...
File tests/language/language.status (right):

https://chromiumcodereview.appspot.com/10913081/diff/5001/tests/language/lang...
tests/language/language.status:74: type_parameter_test/01: Fail
On 2012/09/05 13:50:34, floitsch wrote:
> put the issue number to the right of the failing tests.

Done.

https://chromiumcodereview.appspot.com/10913081/diff/5001/tests/language/lang...
File tests/language/language_dart2js.status (right):

https://chromiumcodereview.appspot.com/10913081/diff/5001/tests/language/lang...
tests/language/language_dart2js.status:43: type_parameter_test/01: Fail
On 2012/09/05 13:50:34, floitsch wrote:
> put the issue number to the right of the failing test.

Done.

Expand Messages | Collapse Messages