Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(14)

Issue 10913058: [OTS] cmap ParseFormat4() should check the first segment (Closed)

Created:
7 years, 5 months ago by bashi
Modified:
7 years, 5 months ago
Reviewers:
Yusuke Sato, agl
CC:
chromium-reviews
Visibility:
Public.

Description

cmap ParseFormat4() should check the first segment R=yusukes@chromium.org,agl@chromium.org BUG=chromium:146254 TEST=ran test/test_{un,}malicious_fonts.sh

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/cmap.cc View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 6 (0 generated)
bashi
Hi Yusuke-san, agl, Could you take a look? I read http://www.microsoft.com/typography/otspec/cmap.htm and I think we ...
7 years, 5 months ago (2012-09-04 01:16:16 UTC) #1
Yusuke Sato
lgtm On 2012/09/04 01:16:16, bashik wrote: > Hi Yusuke-san, agl, > > Could you take ...
7 years, 5 months ago (2012-09-04 04:33:08 UTC) #2
agl
LGTM http://codereview.chromium.org/10913058/diff/3001/src/cmap.cc File src/cmap.cc (right): http://codereview.chromium.org/10913058/diff/3001/src/cmap.cc#newcode215 src/cmap.cc:215: for (unsigned i = 0; i < segcount; ...
7 years, 5 months ago (2012-09-04 13:30:05 UTC) #3
Yusuke Sato
http://codereview.chromium.org/10913058/diff/3001/src/cmap.cc File src/cmap.cc (right): http://codereview.chromium.org/10913058/diff/3001/src/cmap.cc#newcode215 src/cmap.cc:215: for (unsigned i = 0; i < segcount; ++i) ...
7 years, 5 months ago (2012-09-04 17:43:05 UTC) #4
bashi
On 2012/09/04 17:43:05, Yusuke Sato wrote: > http://codereview.chromium.org/10913058/diff/3001/src/cmap.cc > File src/cmap.cc (right): > > http://codereview.chromium.org/10913058/diff/3001/src/cmap.cc#newcode215 ...
7 years, 5 months ago (2012-09-05 10:52:01 UTC) #5
agl
7 years, 5 months ago (2012-09-05 14:07:23 UTC) #6
On Wed, Sep 5, 2012 at 6:52 AM,  <bashi@chromium.org> wrote:
> Agreed. I think it's a mistake. svn blame says that the line was a part of
> "Initial commit".

Opps :(


Cheers

AGL

Powered by Google App Engine
This is Rietveld 408576698