[OTS] cmap ParseFormat4() should check the first segment

src/cmap.cc

Index: src/cmap.cc
===================================================================
--- src/cmap.cc	(revision 94)
+++ src/cmap.cc	(working copy)
@@ -212,7 +212,7 @@
   // A format 4 CMAP subtable is complex. To be safe we simulate a lookup of
   // each code-point defined in the table and make sure that they are all valid
   // glyphs and that we don't access anything out-of-bounds.
-  for (unsigned i = 1; i < segcount; ++i) {
+  for (unsigned i = 0; i < segcount; ++i) {

[agl, 2012/09/04 13:30:05]

Was there a reason why we didn't check the 0-index table previously?

[Yusuke Sato, 2012/09/04 17:43:06]

I guess this is just a careless mistake...  Line 172 above uses 'for (unsigned i
= 1; i < segcount; ++i)' for a valid reason, and we (I??) somehow
copy-and-pasted it?

     for (unsigned cp = ranges[i].start_range; cp <= ranges[i].end_range; ++cp) {
       const uint16_t code_point = cp;
       if (ranges[i].id_range_offset == 0) {