Chromium Code Reviews Chromium Code Reviews
Issue
10912096:
C++ reability review for gab. (Closed)
DescriptionC++ reability review for gab.
Added class ScopedTokenPrivilege in setup_util.[h|cc] to allow elevation of a process' privilege in the current scope while making sure we don't keep the privilege later (as these powerful privileges should be held for as little time as possible). This class is used in uninstall.cc and tested in setup_util_unittest.cc; I left the other files around for you to understand where this all hooks up.
Original review: https://chromiumcodereview.appspot.com/10810021/
I added an illegal (no space after //) comment to each file for them to be picked up. I will remove at the end (and the CQ will also make sure I do as this currently fails presubmit checks).
BUG=146850
(taking on this team refactoring task as part of this readability review).
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155941
Patch Set 1 #
Total comments: 24
Patch Set 2 : rebase on top of http://codereview.chromium.org/10914126/ #Patch Set 3 : Fix method interfaces in install_worker.(cc|h). #Patch Set 4 : addressing code nits #Patch Set 5 : propagate readbility fixes across all files #
Total comments: 1
Patch Set 6 : Fix up last backward if else block found with regex('if \(.* != .*\) \{(\n[^}]*)*\} else') #
Total comments: 14
Patch Set 7 : nits #Patch Set 8 : Fix install_worker_unittest.cc compile #Patch Set 9 : Remove dummy comment used to pickup files for readbility #Patch Set 10 : Fix compile errors #
Messages
Total messages: 14 (0 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
