Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2331)

Unified Diff: chrome/installer/setup/install_worker_unittest.cc

Issue 10912096: C++ reability review for gab. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix compile errors Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/setup/install_worker.cc ('k') | chrome/installer/setup/setup_main.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/setup/install_worker_unittest.cc
diff --git a/chrome/installer/setup/install_worker_unittest.cc b/chrome/installer/setup/install_worker_unittest.cc
index 1a9b8cadc134765de09fca4d0c7cb89b6e7de3cb..dbecc9438a55c5afacce36f6e5d3b30ea3bb73b1 100644
--- a/chrome/installer/setup/install_worker_unittest.cc
+++ b/chrome/installer/setup/install_worker_unittest.cc
@@ -460,8 +460,8 @@ TEST_F(InstallWorkerTest, TestInstallChromeSingleSystem) {
archive_path_,
src_path_,
temp_dir_,
+ current_version_.get(),
*new_version_.get(),
- &current_version_,
&work_item_list);
}
@@ -724,8 +724,8 @@ TEST_F(QuickEnableAbsentTest, CleanInstallSingleChrome) {
InstallerState::SINGLE_INSTALL_OR_UPDATE));
AddQuickEnableChromeFrameWorkItems(*installer_state,
*machine_state_,
- &setup_path_,
- new_version_.get(),
+ setup_path_,
+ *new_version_.get(),
&work_item_list_);
}
@@ -737,8 +737,8 @@ TEST_F(QuickEnableAbsentTest, CleanInstallSingleChromeFrame) {
InstallerState::SINGLE_INSTALL_OR_UPDATE));
AddQuickEnableChromeFrameWorkItems(*installer_state,
*machine_state_,
- &setup_path_,
- new_version_.get(),
+ setup_path_,
+ *new_version_.get(),
&work_item_list_);
}
@@ -750,8 +750,8 @@ TEST_F(QuickEnableAbsentTest, CleanInstallMultiChromeFrame) {
InstallerState::MULTI_INSTALL));
AddQuickEnableChromeFrameWorkItems(*installer_state,
*machine_state_,
- &setup_path_,
- new_version_.get(),
+ setup_path_,
+ *new_version_.get(),
&work_item_list_);
}
@@ -766,8 +766,8 @@ TEST_F(QuickEnableAbsentTest, CleanInstallMultiChromeChromeFrame) {
installer_state.get());
AddQuickEnableChromeFrameWorkItems(*installer_state,
*machine_state_,
- &setup_path_,
- new_version_.get(),
+ setup_path_,
+ *new_version_.get(),
&work_item_list_);
}
@@ -783,8 +783,8 @@ TEST_F(QuickEnableAbsentTest, UninstallMultiChromeLeaveMultiChromeFrame) {
AddChromeToInstallerState(*machine_state_, installer_state.get());
AddQuickEnableChromeFrameWorkItems(*installer_state,
*machine_state_,
- &setup_path_,
- new_version_.get(),
+ setup_path_,
+ *new_version_.get(),
&work_item_list_);
}
@@ -801,8 +801,8 @@ TEST_F(QuickEnableAbsentTest, UninstallMultiChromeLeaveSingleChromeFrame) {
AddChromeBinariesToInstallerState(*machine_state_, installer_state.get());
AddQuickEnableChromeFrameWorkItems(*installer_state,
*machine_state_,
- &setup_path_,
- new_version_.get(),
+ setup_path_,
+ *new_version_.get(),
&work_item_list_);
}
@@ -820,8 +820,8 @@ TEST_F(QuickEnableAbsentTest, AcceptReadyMode) {
AddChromeBinariesToInstallerState(*machine_state_, installer_state.get());
AddQuickEnableChromeFrameWorkItems(*installer_state,
*machine_state_,
- &setup_path_,
- new_version_.get(),
+ setup_path_,
+ *new_version_.get(),
&work_item_list_);
}
@@ -885,8 +885,8 @@ TEST_F(QuickEnablePresentTest, CleanInstallMultiChrome) {
InstallerState::MULTI_INSTALL));
AddQuickEnableChromeFrameWorkItems(*installer_state,
*machine_state_,
- &setup_path_,
- new_version_.get(),
+ setup_path_,
+ *new_version_.get(),
&work_item_list_);
}
@@ -901,8 +901,8 @@ TEST_F(QuickEnablePresentTest, CleanInstallMultiChromeReadyMode) {
installer_state.get());
AddQuickEnableChromeFrameWorkItems(*installer_state,
*machine_state_,
- &setup_path_,
- new_version_.get(),
+ setup_path_,
+ *new_version_.get(),
&work_item_list_);
}
@@ -918,8 +918,8 @@ TEST_F(QuickEnablePresentTest, UninstallSingleChromeFrame) {
AddChromeFrameToInstallerState(*machine_state_, false, installer_state.get());
AddQuickEnableChromeFrameWorkItems(*installer_state,
*machine_state_,
- &setup_path_,
- new_version_.get(),
+ setup_path_,
+ *new_version_.get(),
&work_item_list_);
}
@@ -935,8 +935,8 @@ TEST_F(QuickEnablePresentTest, UninstallMultiChromeFrame) {
AddChromeFrameToInstallerState(*machine_state_, false, installer_state.get());
AddQuickEnableChromeFrameWorkItems(*installer_state,
*machine_state_,
- &setup_path_,
- new_version_.get(),
+ setup_path_,
+ *new_version_.get(),
&work_item_list_);
}
« no previous file with comments | « chrome/installer/setup/install_worker.cc ('k') | chrome/installer/setup/setup_main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698