Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: runtime/vm/assembler_x64.cc

Issue 10912028: Fix computations in LeaveCallRuntimeFrame to use kDoubleSize for saved XMM registers. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_ia32.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_x64.cc
diff --git a/runtime/vm/assembler_x64.cc b/runtime/vm/assembler_x64.cc
index 600b6c9bd8be4703f2621d6a189153aedb8ee61a..697060baedea88a92a805ee57f6612007748b705 100644
--- a/runtime/vm/assembler_x64.cc
+++ b/runtime/vm/assembler_x64.cc
@@ -1699,10 +1699,6 @@ static const intptr_t kNumberOfVolatileXmmRegisters =
kNumberOfXmmRegisters - 1;
-static const intptr_t kNumberOfVolatileRegisters =
- kNumberOfVolatileCpuRegisters + kNumberOfVolatileXmmRegisters;
-
-
void Assembler::EnterCallRuntimeFrame(intptr_t frame_space) {
enter(Immediate(0));
@@ -1730,7 +1726,10 @@ void Assembler::LeaveCallRuntimeFrame() {
// RSP might have been modified to reserve space for arguments
// and ensure proper alignment of the stack frame.
// We need to restore it before restoring registers.
- leaq(RSP, Address(RBP, -kNumberOfVolatileRegisters * kWordSize));
+ const intptr_t kPushedRegistersSize =
+ kNumberOfVolatileCpuRegisters * kWordSize +
+ kNumberOfVolatileXmmRegisters * kDoubleSize;
+ leaq(RSP, Address(RBP, -kPushedRegistersSize));
// Restore all XMM registers except XMM0
// XMM registers have the lowest register number at the lowest address.
« no previous file with comments | « runtime/vm/assembler_ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698