Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Unified Diff: runtime/vm/assembler_ia32.cc

Issue 10912028: Fix computations in LeaveCallRuntimeFrame to use kDoubleSize for saved XMM registers. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/assembler_x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_ia32.cc
diff --git a/runtime/vm/assembler_ia32.cc b/runtime/vm/assembler_ia32.cc
index 956b07b8a35babcdc05db42f11e2069813e5d8d3..6627cd649251cd813b286b9aeb8eaf3ddd8351a4 100644
--- a/runtime/vm/assembler_ia32.cc
+++ b/runtime/vm/assembler_ia32.cc
@@ -1546,10 +1546,6 @@ static const intptr_t kNumberOfVolatileXmmRegisters =
kNumberOfXmmRegisters - 1;
-static const intptr_t kNumberOfVolatileRegisters =
- kNumberOfVolatileCpuRegisters + kNumberOfVolatileXmmRegisters;
-
-
void Assembler::EnterCallRuntimeFrame(intptr_t frame_space) {
enter(Immediate(0));
@@ -1577,7 +1573,10 @@ void Assembler::LeaveCallRuntimeFrame() {
// ESP might have been modified to reserve space for arguments
// and ensure proper alignment of the stack frame.
// We need to restore it before restoring registers.
- leal(ESP, Address(EBP, -kNumberOfVolatileRegisters * kWordSize));
+ const intptr_t kPushedRegistersSize =
+ kNumberOfVolatileCpuRegisters * kWordSize +
+ kNumberOfVolatileXmmRegisters * kDoubleSize;
+ leal(ESP, Address(EBP, -kPushedRegistersSize));
// Restore all XMM registers except XMM0
// XMM registers have the lowest register number at the lowest address.
« no previous file with comments | « no previous file | runtime/vm/assembler_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698