Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 10911317: KeyEvent work. (Closed)

Created:
8 years, 3 months ago by Ben Goodger (Google)
Modified:
8 years, 3 months ago
CC:
chromium-reviews, tfarina, ben+watch_chromium.org
Visibility:
Public.

Description

Gets KeyEvents to work with the new Desktop classes. A few things were required: - Pass a real HWND to InputMethodWin, since it can't rely on Widget::GetNativeView() (NativeView = aura::Window*). - Construct a InputMethodWin in DesktopRootWindowHostWin, and wire up relevant IME messages to it. - Forward key events from DRWHW into the RootWindow, make sure DesktopNativeWidgetAura forwards them to the Widget. http://crbug.com/146077 R=sky@chromium.org,scottmg@chromium.org,erg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156901

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -30 lines) Patch
M ui/views/ime/input_method_win.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/views/ime/input_method_win.cc View 11 chunks +21 lines, -19 lines 0 comments Download
M ui/views/views.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_native_widget_aura.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_root_window_host.h View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_root_window_host_linux.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_root_window_host_linux.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_root_window_host_win.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_root_window_host_win.cc View 6 chunks +44 lines, -4 lines 0 comments Download
M ui/views/widget/native_widget_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Ben Goodger (Google)
sky: review jam/scottmg/erg: fyi as an example of how a fairly complex NOTIMPLEMENTED can be ...
8 years, 3 months ago (2012-09-14 20:25:55 UTC) #1
sky
8 years, 3 months ago (2012-09-14 22:14:46 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698