Chromium Code Reviews
Help | Chromium Project | Sign in
(216)

Issue 10911280: Adding a test to cover XCode UID collisions. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 7 months ago by noyau
Modified:
1 year, 6 months ago
CC:
gyp-developer_googlegroups.com, thakis
Visibility:
Public.

Description

Adding a test to cover XCode UID collisions.

CL https://codereview.appspot.com/6476070/ fixed the issue, this
test verifies that the collision is no longer happening.

r1504

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -12 lines) Lint Patch
M test/same-gyp-name/gyptest-all.py View 1 2 3 4 5 3 chunks +10 lines, -6 lines 1 comment 0 errors Download
M test/same-gyp-name/gyptest-default.py View 1 2 3 4 5 3 chunks +10 lines, -6 lines 0 comments 0 errors Download
A test/same-gyp-name/gyptest-library.py View 1 2 3 4 1 chunk +20 lines, -0 lines 0 comments 0 errors Download
A test/same-gyp-name/library/one/sub.gyp View 1 2 3 4 5 1 chunk +11 lines, -0 lines 0 comments 0 errors Download
A test/same-gyp-name/library/test.gyp View 1 2 3 4 1 chunk +15 lines, -0 lines 0 comments 0 errors Download
A test/same-gyp-name/library/two/sub.gyp View 1 2 3 4 5 1 chunk +11 lines, -0 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 13
noyau
As requested by @thakis in the related CL, this adds a test to cover the ...
1 year, 7 months ago #1
Nico (ooo Apr 18 - Apr 20)
Thanks! https://chromiumcodereview.appspot.com/10911280/diff/1/test/mac/gyptest-duplicate-names.py File test/mac/gyptest-duplicate-names.py (right): https://chromiumcodereview.appspot.com/10911280/diff/1/test/mac/gyptest-duplicate-names.py#newcode16 test/mac/gyptest-duplicate-names.py:16: if sys.platform == 'darwin': The test didn't look ...
1 year, 7 months ago #2
noyau
On 2012/09/13 12:07:23, Nico wrote: > Thanks! > > https://chromiumcodereview.appspot.com/10911280/diff/1/test/mac/gyptest-duplicate-names.py > File test/mac/gyptest-duplicate-names.py (right): > ...
1 year, 7 months ago #3
Nico (ooo Apr 18 - Apr 20)
On 2012/09/13 13:08:28, noyau wrote: > On 2012/09/13 12:07:23, Nico wrote: > > Thanks! > ...
1 year, 7 months ago #4
noyau
PTAL: moved the test and performed a try-bot run as requested. https://chromiumcodereview.appspot.com/10911280/diff/1/test/mac/gyptest-duplicate-names.py File test/mac/gyptest-duplicate-names.py (right): ...
1 year, 7 months ago #5
noyau
PTAL: Now runs with all generators.
1 year, 7 months ago #6
Nico (ooo Apr 18 - Apr 20)
lgtm. Thanks again for adding this! The generator-output folder contains tests for the -Ggenerator_output flag, ...
1 year, 7 months ago #7
noyau
PTAL: Moved the test again and enabled an existing one for xcode as it was ...
1 year, 7 months ago #8
Nico (ooo Apr 18 - Apr 20)
lgtm https://chromiumcodereview.appspot.com/10911280/diff/23001/test/same-gyp-name/gyptest-all.py File test/same-gyp-name/gyptest-all.py (right): https://chromiumcodereview.appspot.com/10911280/diff/23001/test/same-gyp-name/gyptest-all.py#newcode33 test/same-gyp-name/gyptest-all.py:33: chdir1 = chdir2 = 'relocate/src' Do you understand ...
1 year, 7 months ago #9
noyau
On 2012/09/20 12:52:02, Nico wrote: > lgtm > > https://chromiumcodereview.appspot.com/10911280/diff/23001/test/same-gyp-name/gyptest-all.py > File test/same-gyp-name/gyptest-all.py (right): > ...
1 year, 7 months ago #10
Nico (ooo Apr 18 - Apr 20)
> subdir is doing exactly the same : checking the test format and changing chdir ...
1 year, 7 months ago #11
noyau
On 2012/09/20 13:31:54, Nico wrote: > > subdir is doing exactly the same : checking ...
1 year, 7 months ago #12
Nico (ooo Apr 18 - Apr 20)
1 year, 6 months ago #13
r1504. Thanks again!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6