Chromium Code Reviews
Help | Chromium Project | Sign in
(178)

Issue 10911280: Adding a test to cover XCode UID collisions. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 9 months ago by noyau
Modified:
2 years, 9 months ago
CC:
gyp-developer_googlegroups.com, (unused - use chromium)
Visibility:
Public.

Description

Adding a test to cover XCode UID collisions. CL https://codereview.appspot.com/6476070/ fixed the issue, this test verifies that the collision is no longer happening. r1504

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -12 lines) Patch
M test/same-gyp-name/gyptest-all.py View 1 2 3 4 5 3 chunks +10 lines, -6 lines 1 comment Download
M test/same-gyp-name/gyptest-default.py View 1 2 3 4 5 3 chunks +10 lines, -6 lines 0 comments Download
A test/same-gyp-name/gyptest-library.py View 1 2 3 4 1 chunk +20 lines, -0 lines 0 comments Download
A test/same-gyp-name/library/one/sub.gyp View 1 2 3 4 5 1 chunk +11 lines, -0 lines 0 comments Download
A test/same-gyp-name/library/test.gyp View 1 2 3 4 1 chunk +15 lines, -0 lines 0 comments Download
A test/same-gyp-name/library/two/sub.gyp View 1 2 3 4 5 1 chunk +11 lines, -0 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 13 (0 generated)
noyau
As requested by @thakis in the related CL, this adds a test to cover the ...
2 years, 9 months ago (2012-09-13 11:57:04 UTC) #1
Nico
Thanks! https://chromiumcodereview.appspot.com/10911280/diff/1/test/mac/gyptest-duplicate-names.py File test/mac/gyptest-duplicate-names.py (right): https://chromiumcodereview.appspot.com/10911280/diff/1/test/mac/gyptest-duplicate-names.py#newcode16 test/mac/gyptest-duplicate-names.py:16: if sys.platform == 'darwin': The test didn't look ...
2 years, 9 months ago (2012-09-13 12:07:23 UTC) #2
noyau
On 2012/09/13 12:07:23, Nico wrote: > Thanks! > > https://chromiumcodereview.appspot.com/10911280/diff/1/test/mac/gyptest-duplicate-names.py > File test/mac/gyptest-duplicate-names.py (right): > ...
2 years, 9 months ago (2012-09-13 13:08:28 UTC) #3
Nico
On 2012/09/13 13:08:28, noyau wrote: > On 2012/09/13 12:07:23, Nico wrote: > > Thanks! > ...
2 years, 9 months ago (2012-09-14 03:16:40 UTC) #4
noyau
PTAL: moved the test and performed a try-bot run as requested. https://chromiumcodereview.appspot.com/10911280/diff/1/test/mac/gyptest-duplicate-names.py File test/mac/gyptest-duplicate-names.py (right): ...
2 years, 9 months ago (2012-09-14 12:00:35 UTC) #5
noyau
PTAL: Now runs with all generators.
2 years, 9 months ago (2012-09-14 14:21:25 UTC) #6
Nico
lgtm. Thanks again for adding this! The generator-output folder contains tests for the -Ggenerator_output flag, ...
2 years, 9 months ago (2012-09-14 14:34:53 UTC) #7
noyau
PTAL: Moved the test again and enabled an existing one for xcode as it was ...
2 years, 9 months ago (2012-09-20 12:39:24 UTC) #8
Nico
lgtm https://chromiumcodereview.appspot.com/10911280/diff/23001/test/same-gyp-name/gyptest-all.py File test/same-gyp-name/gyptest-all.py (right): https://chromiumcodereview.appspot.com/10911280/diff/23001/test/same-gyp-name/gyptest-all.py#newcode33 test/same-gyp-name/gyptest-all.py:33: chdir1 = chdir2 = 'relocate/src' Do you understand ...
2 years, 9 months ago (2012-09-20 12:52:02 UTC) #9
noyau
On 2012/09/20 12:52:02, Nico wrote: > lgtm > > https://chromiumcodereview.appspot.com/10911280/diff/23001/test/same-gyp-name/gyptest-all.py > File test/same-gyp-name/gyptest-all.py (right): > ...
2 years, 9 months ago (2012-09-20 13:27:30 UTC) #10
Nico
> subdir is doing exactly the same : checking the test format and changing chdir ...
2 years, 9 months ago (2012-09-20 13:31:54 UTC) #11
noyau
On 2012/09/20 13:31:54, Nico wrote: > > subdir is doing exactly the same : checking ...
2 years, 9 months ago (2012-09-20 13:41:44 UTC) #12
Nico
2 years, 9 months ago (2012-09-21 04:55:12 UTC) #13
r1504. Thanks again!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1f9106d