Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 10911262: cc: Scheduler will never process a commit until it receives a vsync tick. (Closed)

Created:
8 years, 3 months ago by reveman
Modified:
8 years, 3 months ago
Reviewers:
jamesr, nduca
CC:
chromium-reviews
Visibility:
Public.

Description

cc: Scheduler will never process a commit until it receives a vsync tick. Add updateResourcesComplete callback to CCScheduler and use this to indicate completion of texture updates instead of calling CCSchedulerClient::hasMoreResourceUpdates when receiving a vsync tick. WebKit bug: https://bugs.webkit.org/show_bug.cgi?id=94721 BUG=123399, 147651 TEST=Added CCTextureUpdateControllerTest.UpdateMoreTextures, CCTextureUpdateControllerTest.HasMoreUpdates and CCTextureUpdateControllerTest.UpdatesCompleteInFiniteTime to cc_unittests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156669

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -79 lines) Patch
M cc/CCScheduler.h View 4 chunks +4 lines, -3 lines 0 comments Download
M cc/CCScheduler.cpp View 5 chunks +17 lines, -3 lines 0 comments Download
M cc/CCSchedulerTest.cpp View 7 chunks +7 lines, -12 lines 0 comments Download
M cc/CCTextureUpdateController.h View 2 chunks +14 lines, -5 lines 0 comments Download
M cc/CCTextureUpdateController.cpp View 4 chunks +19 lines, -14 lines 0 comments Download
M cc/CCTextureUpdateControllerTest.cpp View 9 chunks +47 lines, -27 lines 0 comments Download
M cc/CCThreadProxy.h View 4 chunks +5 lines, -4 lines 0 comments Download
M cc/CCThreadProxy.cpp View 1 5 chunks +10 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
reveman
This is the chromium version of https://bugs.webkit.org/show_bug.cgi?id=94721 but without the discardUpdates part. https://codereview.chromium.org/10914236/ need land ...
8 years, 3 months ago (2012-09-12 20:24:41 UTC) #1
nduca
lgtm
8 years, 3 months ago (2012-09-13 05:31:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/10911262/1
8 years, 3 months ago (2012-09-13 20:44:48 UTC) #3
commit-bot: I haz the power
Failed to apply patch for cc/CCThreadProxy.cpp: While running patch -p1 --forward --force; patching file cc/CCThreadProxy.cpp ...
8 years, 3 months ago (2012-09-13 20:44:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/10911262/5001
8 years, 3 months ago (2012-09-13 20:50:26 UTC) #5
commit-bot: I haz the power
Retried try job too often for step(s) interactive_ui_tests
8 years, 3 months ago (2012-09-13 22:00:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reveman@chromium.org/10911262/5001
8 years, 3 months ago (2012-09-13 22:44:39 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-09-13 23:14:21 UTC) #8
Change committed as 156669

Powered by Google App Engine
This is Rietveld 408576698