Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 10911182: Mark BrowserKeyEventsTest.PageUpDownKeys as flaky. (Closed)

Created:
8 years, 3 months ago by erikwright (departed)
Modified:
8 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/browser_keyevents_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
erikwright (departed)
8 years, 3 months ago (2012-09-10 15:49:45 UTC) #1
Ben Goodger (Google)
8 years, 3 months ago (2012-09-10 15:49:59 UTC) #2
lgtm


On Mon, Sep 10, 2012 at 8:49 AM, <erikwright@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Description:
> Mark BrowserKeyEventsTest.**PageUpDownKeys as flaky.
>
> See:
>
> http://build.chromium.org/p/**chromium/builders/Interactive%**
>
20Tests%20%28dbg%29/builds/**27190/steps/interactive_ui_**tests/logs/stdio<http://build.chromium.org/p/chromium/builders/Interactive%20Tests%20%28dbg%29/builds/27190/steps/interactive_ui_tests/logs/stdio>
> http://build.chromium.org/p/**tryserver.chromium/**
>
buildstatus?builder=linux_rel&**number=54925<http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=54925>
> http://build.chromium.org/p/**tryserver.chromium/builders/**
>
linux_rel/builds/54919/steps/**interactive_ui_tests/logs/**PageUpDownKeys<http://build.chromium.org/p/tryserver.chromium/builders/linux_rel/builds/54919/steps/interactive_ui_tests/logs/PageUpDownKeys>
> ...
>
> TBR=ben@chromium.org
> BUG=147579
>
>
> Please review this at
https://chromiumcodereview.**appspot.com/10911182/<https://chromiumcodereview...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M chrome/browser/browser_**keyevents_browsertest.cc
>
>
> Index: chrome/browser/browser_**keyevents_browsertest.cc
> diff --git a/chrome/browser/browser_**keyevents_browsertest.cc
> b/chrome/browser/browser_**keyevents_browsertest.cc
> index f58100df72fb2570844caf8ca5bbb5**7c933c40aa..**
> 78299ee71093bbe32a2fafc9125e26**b2ca2d82ae 100644
> --- a/chrome/browser/browser_**keyevents_browsertest.cc
> +++ b/chrome/browser/browser_**keyevents_browsertest.cc
> @@ -804,7 +804,8 @@ IN_PROC_BROWSER_TEST_F(**BrowserKeyEventsTest,
> EditorKeyBindings) {
>  }
>  #endif
>
> -IN_PROC_BROWSER_TEST_F(**BrowserKeyEventsTest, PageUpDownKeys) {
> +// See http://crbug.com/147579
> +IN_PROC_BROWSER_TEST_F(**BrowserKeyEventsTest, FLAKY_PageUpDownKeys) {
>    static const KeyEventTestData kTestPageUp = {
>      ui::VKEY_PRIOR, false, false, false, false,
>      false, false, false, false, 2,
>
>
>

Powered by Google App Engine
This is Rietveld 408576698