Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Side by Side Diff: chrome/browser/browser_keyevents_browsertest.cc

Issue 10911182: Mark BrowserKeyEventsTest.PageUpDownKeys as flaky. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "build/build_config.h" 5 #include "build/build_config.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/message_loop.h" 9 #include "base/message_loop.h"
10 #include "base/stringprintf.h" 10 #include "base/stringprintf.h"
(...skipping 786 matching lines...) Expand 10 before | Expand all | Expand 10 after
797 // Move the caret to the beginning of the line. 797 // Move the caret to the beginning of the line.
798 EXPECT_NO_FATAL_FAILURE(TestKeyEvent(tab_index, kTestCtrlA)); 798 EXPECT_NO_FATAL_FAILURE(TestKeyEvent(tab_index, kTestCtrlA));
799 // Forward one character 799 // Forward one character
800 EXPECT_NO_FATAL_FAILURE(TestKeyEvent(tab_index, kTestCtrlF)); 800 EXPECT_NO_FATAL_FAILURE(TestKeyEvent(tab_index, kTestCtrlF));
801 // Delete to the end of the line. 801 // Delete to the end of the line.
802 EXPECT_NO_FATAL_FAILURE(TestKeyEvent(tab_index, kTestCtrlK)); 802 EXPECT_NO_FATAL_FAILURE(TestKeyEvent(tab_index, kTestCtrlK));
803 EXPECT_NO_FATAL_FAILURE(CheckTextBoxValue(tab_index, L"A", L"H")); 803 EXPECT_NO_FATAL_FAILURE(CheckTextBoxValue(tab_index, L"A", L"H"));
804 } 804 }
805 #endif 805 #endif
806 806
807 IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, PageUpDownKeys) { 807 // See http://crbug.com/147579
808 IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, FLAKY_PageUpDownKeys) {
808 static const KeyEventTestData kTestPageUp = { 809 static const KeyEventTestData kTestPageUp = {
809 ui::VKEY_PRIOR, false, false, false, false, 810 ui::VKEY_PRIOR, false, false, false, false,
810 false, false, false, false, 2, 811 false, false, false, false, 2,
811 { "D 33 0 false false false false", 812 { "D 33 0 false false false false",
812 "U 33 0 false false false false" } 813 "U 33 0 false false false false" }
813 }; 814 };
814 815
815 static const KeyEventTestData kTestPageDown = { 816 static const KeyEventTestData kTestPageDown = {
816 ui::VKEY_NEXT, false, false, false, false, 817 ui::VKEY_NEXT, false, false, false, false,
817 false, false, false, false, 2, 818 false, false, false, false, 2,
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
882 EXPECT_NO_FATAL_FAILURE(TestKeyEvent(tab_index, kTestAltKeySuppress)); 883 EXPECT_NO_FATAL_FAILURE(TestKeyEvent(tab_index, kTestAltKeySuppress));
883 ASSERT_TRUE(IsViewFocused(VIEW_ID_TAB_CONTAINER)); 884 ASSERT_TRUE(IsViewFocused(VIEW_ID_TAB_CONTAINER));
884 885
885 // Ctrl+Alt should have no effect. 886 // Ctrl+Alt should have no effect.
886 EXPECT_NO_FATAL_FAILURE(TestKeyEvent(tab_index, kTestCtrlAltKey)); 887 EXPECT_NO_FATAL_FAILURE(TestKeyEvent(tab_index, kTestCtrlAltKey));
887 ASSERT_TRUE(IsViewFocused(VIEW_ID_TAB_CONTAINER)); 888 ASSERT_TRUE(IsViewFocused(VIEW_ID_TAB_CONTAINER));
888 } 889 }
889 #endif 890 #endif
890 891
891 } // namespace 892 } // namespace
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698