URLRequestHttpJob::StartTransaction should honour network delegate.

chrome_frame/test/net/fake_external_tab.cc

Index: chrome_frame/test/net/fake_external_tab.cc
diff --git a/chrome_frame/test/net/fake_external_tab.cc b/chrome_frame/test/net/fake_external_tab.cc
index 860869616a353454929b4375a0f577d21e67571c..943bdcde2bbff12ad1641dc61ab5522f6502d72a 100644
--- a/chrome_frame/test/net/fake_external_tab.cc
+++ b/chrome_frame/test/net/fake_external_tab.cc
@@ -208,6 +208,13 @@ void FilterDisabledTests() {
     // the second state is not supported by CF.
     "URLRequestTestHTTP.NetworkDelegateBlockAsynchronously",
 
+    // Tests for cancelling requests in states OnBeforeSendHeaders and
+    // OnHeadersReceived, which do not seem supported by CF.

[battre, 2012/09/27 07:24:30]

Why are they not supported? This looks like a weak argument.

[vabr (Chromium), 2012/09/27 18:15:12]

I was re-using the argument from other parts of this file (see below).
Note that there is still actually one more test run for Chrome Frame after this
CL, compared to the state before.
I don't think there is a way to run these 4 tests under Chrome Frame, the stages
in which they block do not seem to be ever visited.

+    "URLRequestTestHTTP.NetworkDelegateCancelRequestSynchronously2",
+    "URLRequestTestHTTP.NetworkDelegateCancelRequestSynchronously3",
+    "URLRequestTestHTTP.NetworkDelegateCancelRequestAsynchronously2",
+    "URLRequestTestHTTP.NetworkDelegateCancelRequestAsynchronously3",
+
     // Tests that requests can be cancelled while blocking in
     // OnBeforeSendHeaders state. But this state is not supported by CF.
     "URLRequestTestHTTP.NetworkDelegateCancelWhileWaiting2",