URLRequestHttpJob::StartTransaction should honour network delegate.

chrome_frame/test/net/fake_external_tab.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome_frame/test/net/fake_external_tab.h"
 
 #include <atlbase.h>
 #include <atlcom.h>
 #include <exdisp.h>
 #include <Winsock2.h>
@@ skipping 190 matching lines @@
 
     // Tests chrome's network stack's cache (might not apply to CF).
     "URLRequestTestHTTP.VaryHeader",
     "URLRequestTestHTTP.GetZippedTest",
 
     // Tests that requests can be blocked asynchronously in states
     // OnBeforeURLRequest, OnBeforeSendHeaders and OnHeadersReceived. At least
     // the second state is not supported by CF.
     "URLRequestTestHTTP.NetworkDelegateBlockAsynchronously",
 
+    // Tests for cancelling requests in states OnBeforeSendHeaders and
+    // OnHeadersReceived, which do not seem supported by CF.

[battre, 2012/09/27 07:24:30]

Why are they not supported? This looks like a weak argument.

[vabr (Chromium), 2012/09/27 18:15:12]

I was re-using the argument from other parts of this file (see below).
Note that there is still actually one more test run for Chrome Frame after this
CL, compared to the state before.
I don't think there is a way to run these 4 tests under Chrome Frame, the stages
in which they block do not seem to be ever visited.

+    "URLRequestTestHTTP.NetworkDelegateCancelRequestSynchronously2",
+    "URLRequestTestHTTP.NetworkDelegateCancelRequestSynchronously3",
+    "URLRequestTestHTTP.NetworkDelegateCancelRequestAsynchronously2",
+    "URLRequestTestHTTP.NetworkDelegateCancelRequestAsynchronously3",
+
     // Tests that requests can be cancelled while blocking in
     // OnBeforeSendHeaders state. But this state is not supported by CF.
     "URLRequestTestHTTP.NetworkDelegateCancelWhileWaiting2",
 
     // Tests that requests can be cancelled while blocking in
     // OnHeadersRecevied state. At first glance, this state does not appear to
     // be supported by CF.
     "URLRequestTestHTTP.NetworkDelegateCancelWhileWaiting3",
 
     // Tests that requests can be cancelled while blocking in OnAuthRequired
@@ skipping 711 matching lines @@
   // content::InitializeSandboxInfo(&sandbox_info);
   FakeMainDelegate delegate;
   content::ContentMain(
       reinterpret_cast<HINSTANCE>(GetModuleHandle(NULL)),
       &sandbox_info,
       &delegate);
 
   // Note:  In debug builds, we ExitProcess during PostDestroyThreads.
   return g_test_suite->test_result();
 }