Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: bin/gen_snapshot.cc

Issue 10911135: Simplify the builtin functions and get rid of unused code. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « bin/dartutils.cc ('k') | bin/main.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: bin/gen_snapshot.cc
===================================================================
--- bin/gen_snapshot.cc (revision 11998)
+++ bin/gen_snapshot.cc (working copy)
@@ -197,9 +197,7 @@
// Load the builtin library to make it available in the snapshot
// for importing.
lib = Builtin::LoadAndCheckLibrary(id);
- if (!Dart_IsError(lib)) {
- Builtin::SetupLibrary(lib, id);
- }
+ ASSERT(!Dart_IsError(lib));
return lib;
}
@@ -260,14 +258,14 @@
Dart_Handle library =
LoadGenericSnapshotCreationScript(Builtin::kBuiltinLibrary);
VerifyLoaded(library);
- library = LoadGenericSnapshotCreationScript(Builtin::kCryptoLibrary);
- VerifyLoaded(library);
- library = LoadGenericSnapshotCreationScript(Builtin::kIOLibrary);
- VerifyLoaded(library);
library = LoadGenericSnapshotCreationScript(Builtin::kJsonLibrary);
VerifyLoaded(library);
library = LoadGenericSnapshotCreationScript(Builtin::kUriLibrary);
VerifyLoaded(library);
+ library = LoadGenericSnapshotCreationScript(Builtin::kCryptoLibrary);
+ VerifyLoaded(library);
+ library = LoadGenericSnapshotCreationScript(Builtin::kIOLibrary);
+ VerifyLoaded(library);
library = LoadGenericSnapshotCreationScript(Builtin::kUtfLibrary);
VerifyLoaded(library);
}
« no previous file with comments | « bin/dartutils.cc ('k') | bin/main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698