Test dart2js checked mode.

dart/utils/compiler/buildbot.py

Index: dart/utils/compiler/buildbot.py
diff --git a/dart/utils/compiler/buildbot.py b/dart/utils/compiler/buildbot.py
index 5020e4df6f474936fdfa02f6c8c0c8b4697e63d6..14f096d62e406d1771ec45a00bf7941fbced770d 100644
--- a/dart/utils/compiler/buildbot.py
+++ b/dart/utils/compiler/buildbot.py
@@ -165,6 +165,11 @@ def TestCompiler(runtime, mode, system, option, flags, is_buildbot):
   os.chdir(DART_PATH)
 
   if system.startswith('win') and runtime == 'ie':
+    # TODO(ahe): This pre-dates the shard feature and should be

[kasperl, 2012/09/05 11:54:20]

It actually doesn't predate sharding. I changed it to use sharding at some
point, but it was changed back (by Emily if I recall correctly) because people
preferred a slow and a fast bot.

Personally, I prefer the simplicity of using the generic sharding because the
current way makes it super easy to forget adding new test suites to one or the
other IE bot.

[Emily Fortuna, 2012/09/05 16:28:53]

Yes, Peter, this comment is incorrect. This was done after sharding was
implemented so that we could have some fast feedback on Windows bots by focusing
on tests that were most likely to be affected by the browser environment on our
fast bot. See the comment immediately below this for that explanation.

[ahe, 2012/09/05 19:24:30]

The only part of the comment that is incorrect is "this pre-dates the shard
feature".

Sharding can be used to implement this.

The problem with the current solution is that it requires constant maintenance.
Explicit lists of test suites quickly become obsolete, and that has already
happened. For example, 'pkg' and 'dartdoc' are in defaultTestSelectors in
tools/testing/dart/test_options.dart, but not below.

+    # removed. If we want to have a fast and a slow bot, that should
+    # be accomplished by having several shards distributed on multiple
+    # virtual builders.
+
     # We don't do proper sharding on the IE bots, since the runtime is
     # long for both. We have a "fast bot" and a "slow bot" that run specific
     # tests instead.
@@ -234,6 +239,8 @@ def TestCompiler(runtime, mode, system, option, flags, is_buildbot):
     extras = ['dart2js_extra', 'dart2js_native', 'dart2js_foreign']
     TestStep("dart2js_extra", mode, system, 'dart2js', runtime, extras, flags)
   else:
+    # TODO(ahe): See comment above regarding how to use sharding to

[Emily Fortuna, 2012/09/05 16:28:53]

Please remove -- this comment is incorrect.

+    # accomplish the same.
     if bot_num == '1':
       TestStep("dart2js", mode, system, 'dart2js', runtime, ['html'], flags)
     else:
@@ -332,8 +339,7 @@ def main():
   status = TestCompiler(runtime, mode, system, option, test_flags,
                         is_buildbot)
 
-  # We only run checked mode tests when the host is not in checked mode.
-  if status == 0 and option != 'checked' and runtime == 'd8':
+  if status == 0:
     status = TestCompiler(runtime, mode, system, option,
                           test_flags + ['--checked'], is_buildbot)