Test dart2js checked mode.

dart/utils/compiler/buildbot.py

 #!/usr/bin/python
 
 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Dart2js buildbot steps
 
 Runs tests for the  dart2js compiler.
 """
@@ skipping 147 matching lines @@
      - option: 'checked'
      - flags: extra flags to pass to test.dart
      - is_buildbot: true if we are running on a real buildbot instead of
        emulating one.
   """
 
   # Make sure we are in the dart directory
   os.chdir(DART_PATH)
 
   if system.startswith('win') and runtime == 'ie':
+    # TODO(ahe): This pre-dates the shard feature and should be

[kasperl, 2012/09/05 11:54:20]

It actually doesn't predate sharding. I changed it to use sharding at some
point, but it was changed back (by Emily if I recall correctly) because people
preferred a slow and a fast bot.

Personally, I prefer the simplicity of using the generic sharding because the
current way makes it super easy to forget adding new test suites to one or the
other IE bot.

[Emily Fortuna, 2012/09/05 16:28:53]

Yes, Peter, this comment is incorrect. This was done after sharding was
implemented so that we could have some fast feedback on Windows bots by focusing
on tests that were most likely to be affected by the browser environment on our
fast bot. See the comment immediately below this for that explanation.

[ahe, 2012/09/05 19:24:30]

The only part of the comment that is incorrect is "this pre-dates the shard
feature".

Sharding can be used to implement this.

The problem with the current solution is that it requires constant maintenance.
Explicit lists of test suites quickly become obsolete, and that has already
happened. For example, 'pkg' and 'dartdoc' are in defaultTestSelectors in
tools/testing/dart/test_options.dart, but not below.

+    # removed. If we want to have a fast and a slow bot, that should
+    # be accomplished by having several shards distributed on multiple
+    # virtual builders.
+
     # We don't do proper sharding on the IE bots, since the runtime is
     # long for both. We have a "fast bot" and a "slow bot" that run specific
     # tests instead.
     for i in flags:
       if i.startswith('--shard='):
         bot_num = i.split('=')[1]
     # There should not be more than one InternetExplorerDriver instance
     # running at a time. For details, see
     # http://code.google.com/p/selenium/wiki/InternetExplorerDriver.
     flags = (filter(lambda(item): not item.startswith('--shard'), flags) +
@@ skipping 49 matching lines @@
     TestStep("dart2js_unit", mode, system, 'none', 'vm', ['dart2js'], flags)
 
   if not (system.startswith('win') and runtime == 'ie'):
     # Run the default set of test suites.
     TestStep("dart2js", mode, system, 'dart2js', runtime, [], flags)
 
     # TODO(kasperl): Consider running peg and css tests too.
     extras = ['dart2js_extra', 'dart2js_native', 'dart2js_foreign']
     TestStep("dart2js_extra", mode, system, 'dart2js', runtime, extras, flags)
   else:
+    # TODO(ahe): See comment above regarding how to use sharding to

[Emily Fortuna, 2012/09/05 16:28:53]

Please remove -- this comment is incorrect.

+    # accomplish the same.
     if bot_num == '1':
       TestStep("dart2js", mode, system, 'dart2js', runtime, ['html'], flags)
     else:
       TestStep("dart2js", mode, system, 'dart2js', runtime, ['dartc',
           'samples', 'standalone', 'corelib', 'co19', 'language', 'isolate',
           'vm', 'json', 'benchmark_smoke', 'dartdoc', 'utils', 'pub', 'lib'],
           flags)
       extras = ['dart2js_extra', 'dart2js_native', 'dart2js_foreign']
       TestStep("dart2js_extra", mode, system, 'dart2js', runtime, extras,
           flags)
@@ skipping 78 matching lines @@
     return status
 
   test_flags = []
   if shard_index:
     test_flags = ['--shards=%s' % total_shards, '--shard=%s' % shard_index]
 
   # First we run all the regular tests.
   status = TestCompiler(runtime, mode, system, option, test_flags,
                         is_buildbot)
 
-  # We only run checked mode tests when the host is not in checked mode.
-  if status == 0 and option != 'checked' and runtime == 'd8':
+  if status == 0:
     status = TestCompiler(runtime, mode, system, option,
                           test_flags + ['--checked'], is_buildbot)
 
   if runtime != 'd8': CleanUpTemporaryFiles(system, runtime)
   if status != 0: print '@@@STEP_FAILURE@@@'
   return status
 
 if __name__ == '__main__':
   sys.exit(main())