Codegen support for the argument definition test.

Codegen support for the argument definition test.
Committed: https://code.google.com/p/dart/source/detail?r=11814

[ngeoffray, 2012-09-04 10:29:50]

PTAL

[kasperl, 2012-09-04 10:50:08]

https://chromiumcodereview.appspot.com/10911062/diff/1/lib/compiler/implement...
File lib/compiler/implementation/closure.dart (right):

https://chromiumcodereview.appspot.com/10911062/diff/1/lib/compiler/implement...
lib/compiler/implementation/closure.dart:332: String name =
'${parameterName.slowToString()}_check';
Is it a problem if this conflicts with other parameter/local names?

https://chromiumcodereview.appspot.com/10911062/diff/1/lib/compiler/implement...
File lib/compiler/implementation/js_backend/emitter.dart (right):

https://chromiumcodereview.appspot.com/10911062/diff/1/lib/compiler/implement...
lib/compiler/implementation/js_backend/emitter.dart:17: Element
getOutermostEnclosingMemberOrTopLevel() {
=> methodElement

https://chromiumcodereview.appspot.com/10911062/diff/1/lib/compiler/implement...
lib/compiler/implementation/js_backend/emitter.dart:346: // Note that [elements]
may be null for a synthetized [member].
Maybe move this comment closer to where you use elements? It feels misplaced
here.

https://chromiumcodereview.appspot.com/10911062/diff/1/lib/compiler/implement...
File lib/compiler/implementation/resolver.dart (right):

https://chromiumcodereview.appspot.com/10911062/diff/1/lib/compiler/implement...
lib/compiler/implementation/resolver.dart:16: final Set<Element>
checkedParameters;
Thanks for trying to come up with a better name. Checked is a bit confusing
because we also have checked mode.

https://chromiumcodereview.appspot.com/10911062/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/builder.dart (right):

https://chromiumcodereview.appspot.com/10911062/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/builder.dart:1843: if (value === '?') {
node.isParameterCheck?

[ngeoffray, 2012-09-04 10:53:44]

https://chromiumcodereview.appspot.com/10911062/diff/1/lib/compiler/implement...
File lib/compiler/implementation/closure.dart (right):

https://chromiumcodereview.appspot.com/10911062/diff/1/lib/compiler/implement...
lib/compiler/implementation/closure.dart:332: String name =
'${parameterName.slowToString()}_check';
On 2012/09/04 10:50:08, kasperl wrote:
> Is it a problem if this conflicts with other parameter/local names?

No, the namer will disambiguate the elements.

https://chromiumcodereview.appspot.com/10911062/diff/1/lib/compiler/implement...
File lib/compiler/implementation/js_backend/emitter.dart (right):

https://chromiumcodereview.appspot.com/10911062/diff/1/lib/compiler/implement...
lib/compiler/implementation/js_backend/emitter.dart:17: Element
getOutermostEnclosingMemberOrTopLevel() {
On 2012/09/04 10:50:08, kasperl wrote:
> => methodElement

Done.

https://chromiumcodereview.appspot.com/10911062/diff/1/lib/compiler/implement...
lib/compiler/implementation/js_backend/emitter.dart:346: // Note that [elements]
may be null for a synthetized [member].
On 2012/09/04 10:50:08, kasperl wrote:
> Maybe move this comment closer to where you use elements? It feels misplaced
> here.

Done.

https://chromiumcodereview.appspot.com/10911062/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/builder.dart (right):

https://chromiumcodereview.appspot.com/10911062/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/builder.dart:1843: if (value === '?') {
On 2012/09/04 10:50:08, kasperl wrote:
> node.isParameterCheck?

Done.

[ngeoffray, 2012-09-04 12:13:17]

Florian suggested to always have elements for parameter check instructions (eg
even when the parameter check is not being used in a closure).

I implemented it, and makes the code a bit cleaner (no more special casing in
the builder).

PTAL

[floitsch, 2012-09-04 13:09:31]

LGTM. thanks.

https://chromiumcodereview.appspot.com/10911062/diff/6001/lib/compiler/implem...
File lib/compiler/implementation/ssa/builder.dart (right):

https://chromiumcodereview.appspot.com/10911062/diff/6001/lib/compiler/implem...
lib/compiler/implementation/ssa/builder.dart:1271: Element redirect =
closureData.parametersWithSentinel[element];
s/redirect/checkResultElement ?
(now that it is not just for redirects anymore).

[ngeoffray, 2012-09-04 13:17:18]

https://chromiumcodereview.appspot.com/10911062/diff/6001/lib/compiler/implem...
File lib/compiler/implementation/ssa/builder.dart (right):

https://chromiumcodereview.appspot.com/10911062/diff/6001/lib/compiler/implem...
lib/compiler/implementation/ssa/builder.dart:1271: Element redirect =
closureData.parametersWithSentinel[element];
On 2012/09/04 13:09:31, floitsch wrote:
> s/redirect/checkResultElement ?
> (now that it is not just for redirects anymore).

Done.