Codegen support for the argument definition test.

lib/compiler/implementation/ssa/builder.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class Interceptors {
   Compiler compiler;
   Interceptors(Compiler this.compiler);
 
   SourceString mapOperatorToMethodName(Operator op) {
     String name = op.source.stringValue;
@@ skipping 788 matching lines @@
 
 class SsaBuilder extends ResolvedVisitor implements Visitor {
   final SsaBuilderTask builder;
   final Interceptors interceptors;
   final WorkItem work;
   bool methodInterceptionEnabled;
   HGraph graph;
   LocalsHandler localsHandler;
   HInstruction rethrowableException;
   Map<Element, HParameterValue> parameters;
+  Map<Element, HInstruction> parametersWithSentinel;
 
   Map<TargetElement, JumpHandler> jumpTargets;
 
   /**
    * Variables stored in the current activation. These variables are
    * being updated in try/catch blocks, and should be
-   * accessed indirectly through HFieldGet and HFieldSet.
+   * accessed indirectly through [HLocalGet] and [HLocalSet].
    */
   Map<Element, HLocalValue> activationVariables;
 
   // We build the Ssa graph by simulating a stack machine.
   List<HInstruction> stack;
 
   // The current block to add instructions to. Might be null, if we are
   // visiting dead code.
   HBasicBlock current;
   // The most recently opened block. Has the same value as [current] while
   // the block is open, but unlike [current], it isn't cleared when the current
   // block is closed.
   HBasicBlock lastOpenedBlock;
 
   LibraryElement get currentLibrary => work.element.getLibrary();
   Compiler get compiler => builder.compiler;
   CodeEmitterTask get emitter => builder.emitter;
 
   SsaBuilder(SsaBuilderTask builder, WorkItem work)
     : this.builder = builder,
       this.work = work,
       interceptors = builder.interceptors,
       methodInterceptionEnabled = true,
       graph = new HGraph(),
       stack = new List<HInstruction>(),
       activationVariables = new Map<Element, HLocalValue>(),
       jumpTargets = new Map<TargetElement, JumpHandler>(),
       parameters = new Map<Element, HParameterValue>(),
+      parametersWithSentinel = new Map<Element, HInstruction>(),
       inliningStack = <InliningState>[],
       super(work.resolutionTree) {
     localsHandler = new LocalsHandler(this);
   }
 
   static const MAX_INLINING_DEPTH = 3;
   static const MAX_INLINING_SOURCE_SIZE = 100;
   List<InliningState> inliningStack;
   Element returnElement = null;
 
@@ skipping 365 matching lines @@
       // these selectors. Maybe the resolver can do more of the work
       // for us here?
       LibraryElement library = body.getLibrary();
       Selector selector = new Selector.call(name, library, arity);
       add(new HInvokeDynamicMethod(selector, bodyCallInputs));
     }
     close(new HReturn(newObject)).addSuccessor(graph.exit);
     return closeFunction();
   }
 
+  void addParameterCheckInstruction(Element element) {
+    // This is the code we emit for a parameter that is being checked
+    // on whether it was given at value at the call site:
+    //
+    // foo([a = 42) {
+    //   if (?a) print('parameter passed $a');
+    // }
+    //
+    // foo([a = 42]) {
+    //   var t1 = a === sentinel;
+    //   if (t1) a = 42;
+    //   if (!t1) print('parameter passed ' + a);
+    // }
+
+    // Fetch the original default value of [element];
+    ConstantHandler handler = compiler.constantHandler;
+    Constant constant = handler.compileVariable(element);
+    HConstant defaultValue = constant == null
+        ? graph.addConstantNull()
+        : graph.addConstant(constant);
+
+    // Emit the equality check with the sentinel.
+    HConstant sentinel = graph.addConstant(SentinelConstant.SENTINEL);
+    Element equalsHelper = interceptors.getTripleEqualsInterceptor();
+    HInstruction target = new HStatic(equalsHelper);
+    add(target);
+    HInstruction operand = parameters[element];
+    HInstruction check = new HIdentity(target, sentinel, operand);
+    add(check);
+
+    // If the check succeeds, we must update the parameter with the
+    // default value.
+    handleIf(element.parseNode(compiler),
+             () => stack.add(check),
+             () => localsHandler.updateLocal(element, defaultValue),
+             null);
+
+    // Create the instruction that parameter checks will use.
+    check = new HNot(check);
+    add(check);
+
+    // If the parameter check is also used by closures,
+    // we need to update the closure field holding that check.
+    ClosureClassMap closureData = localsHandler.closureData;
+    Element redirect = closureData.parametersWithSentinel[element];
+    if (redirect != null) {
+      localsHandler.updateLocal(redirect, check);
+    }
+    // Cache the check so that uses in this method share the same
+    // check instruction.
+    parametersWithSentinel[element] = check;
+  }
+
   void openFunction(FunctionElement functionElement,
                     FunctionExpression node) {
     HBasicBlock block = graph.addNewBlock();
     open(graph.entry);
 
     localsHandler.startFunction(functionElement, node);
     close(new HGoto()).addSuccessor(block);
 
     open(block);
 
+    FunctionSignature params = functionElement.computeSignature(compiler);
+    params.forEachParameter((Element element) {
+      if (elements.isParameterChecked(element)) {
+        addParameterCheckInstruction(element);
+      }
+    });
+
     // Put the type checks in the first successor of the entry,
     // because that is where the type guards will also be inserted.
     // This way we ensure that a type guard will dominate the type
     // check.
-    FunctionSignature params = functionElement.computeSignature(compiler);
     params.forEachParameter((Element element) {
       HInstruction newParameter = potentiallyCheckType(
           localsHandler.directLocals[element], element);
       localsHandler.directLocals[element] = newParameter;
     });
 
     // Add the type parameters of the class as parameters of this
     // method.
     if (functionElement.isFactoryConstructor()
         || functionElement.isGenerativeConstructor()) {
@@ skipping 518 matching lines @@
 
   void visitLogicalNot(Send node) {
     assert(node.argumentsNode is Prefix);
     visit(node.receiver);
     HNot not = new HNot(popBoolified());
     pushWithPosition(not, node);
   }
 
   void visitUnary(Send node, Operator op) {
     String value = op.source.stringValue;
     if (value === '?') {

[kasperl, 2012/09/04 10:50:08]

node.isParameterCheck?

[ngeoffray, 2012/09/04 10:53:44]

Done.

-      // TODO(ahe): Implement argument definition test.
-      stack.add(graph.addConstantBool(true));
+      Element element = elements[node.receiver];
+      // If the parameter we're accessing is from the current
+      // function, we can just fetch the cached instruction.
+      HInstruction check = parametersWithSentinel[element];
+      if (check !== null) {
+        stack.add(check);
+      } else {
+        // The parameter is from an outer function. Lookup the
+        // element in the closure data of the outer function and read
+        // it.
+        assert(element.enclosingElement != work.element);
+        Node node = element.enclosingElement.parseNode(compiler);
+        ClosureClassMap parameterClosureData =
+            compiler.closureToClassMapper.getMappingForNestedFunction(node);
+        Element fieldCheck =
+            parameterClosureData.parametersWithSentinel[element];
+        stack.add(localsHandler.readLocal(fieldCheck));
+      }
       return;
     }
     assert(node.argumentsNode is Prefix);
     visit(node.receiver);
     assert(op.token.kind !== PLUS_TOKEN);
     HInstruction operand = pop();
 
     HInstruction target =
         new HStatic(interceptors.getPrefixOperatorInterceptor(op));
     add(target);
@@ skipping 363 matching lines @@
    */
   bool addStaticSendArgumentsToList(Selector selector,
                                     Link<Node> arguments,
                                     FunctionElement element,
                                     List<HInstruction> list) {
     HInstruction compileArgument(Node argument) {
       visit(argument);
       return pop();
     }
 
-    HInstruction compileConstant(Element constantElement) {
-      Constant constant = compiler.compileVariable(constantElement);
+    HInstruction compileConstant(Element parameter) {
+      Constant constant;
+      TreeElements calleeElements =
+          compiler.enqueuer.resolution.getCachedElements(element);
+      if (calleeElements.isParameterChecked(parameter)) {
+        constant = SentinelConstant.SENTINEL;
+      } else {
+        constant = compiler.compileVariable(parameter);
+      }
       return graph.addConstant(constant);
     }
 
     return selector.addArgumentsToList(arguments,
                                        list,
                                        element,
                                        compileArgument,
                                        compileConstant,
                                        compiler);
   }
@@ skipping 1482 matching lines @@
   }
 
   void visitFunctionExpression(Node node) {
     tooDifficult = true;
   }
 
   void visitFunctionDeclaration(Node node) {
     tooDifficult = true;
   }
 
-  void visitSend(Node node) {
+  void visitSend(Send node) {
+    if (node.isParameterCheck) {
+      tooDifficult = true;
+      return;
+    }
     node.visitChildren(this);
   }
 
   visitLoop(Node node) {
     node.visitChildren(this);
     if (seenReturn) tooDifficult = true;
   }
 
   void visitReturn(Node node) {
     if (seenReturn || node.getBeginToken().stringValue === 'native') {
@@ skipping 250 matching lines @@
           new HSubGraphBlockInformation(elseBranch.graph));
 
     HBasicBlock conditionStartBlock = conditionBranch.block;
     conditionStartBlock.setBlockFlow(info, joinBlock);
     SubGraph conditionGraph = conditionBranch.graph;
     HIf branch = conditionGraph.end.last;
     assert(branch is HIf);
     branch.blockInformation = conditionStartBlock.blockFlow;
   }
 }