Enable Chrome Sandbox with run_test_cases.py

Enable Chrome Sandbox with in test_env.py

Properly setup the chrome sandbox when running test_env.py, if it is required.

R=maruel@chromium.org
BUG=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154297

[M-A Ruel, 2012-08-30 18:47:37]

https://chromiumcodereview.appspot.com/10911014/diff/1/tools/isolate/run_test...
File tools/isolate/run_test_cases.py (right):

https://chromiumcodereview.appspot.com/10911014/diff/1/tools/isolate/run_test...
tools/isolate/run_test_cases.py:583: # Setup the chrome sandbox, using the
default path if no path is specified.
This code doesn't belong here, run_test_cases.py is mostly gtest specific and
_not_ chromium specific. This code belong in testing/test_env.py or a new script
called by it. That would mean updating the relevant .isolate files. This would
probably make sense since base_unittests probably doesn't need the sandbox.

[csharp, 2012-08-30 19:17:11]

Ok, I moved the code into test_env.py. It sense reasonable to just enable this
by default for all tests so we don't have different starting conditions for
different tests,  and all the enabling it does is set an environment variable
(which should be the only cost if the tests don't require the sandbox).

[M-A Ruel, 2012-08-30 19:43:17]

lgtm with nit

https://chromiumcodereview.appspot.com/10911014/diff/4001/testing/test_env.py
File testing/test_env.py (right):

https://chromiumcodereview.appspot.com/10911014/diff/4001/testing/test_env.py...
testing/test_env.py:41: chrome_sandbox_path = CHROME_SANDBOX_PATH
1 line:
chrome_sandbox_path = env.get(CHROME_SANDBOX_ENV, CHROME_SANDBOX_PATH)

https://chromiumcodereview.appspot.com/10911014/diff/4001/testing/test_env.py...
testing/test_env.py:44: print 'Enabling sandbox. Setting environment variable:'
I'd prefer no output except for errors. At worst, some off-by-default logging.

https://chromiumcodereview.appspot.com/10911014/diff/4001/testing/xvfb.py
File testing/xvfb.py (right):

https://chromiumcodereview.appspot.com/10911014/diff/4001/testing/xvfb.py#new...
testing/xvfb.py:116: print >> sys.stderr, 'Failed to run %s' % ' '.join(ice_cmd)
Argh. Thanks!

[csharp, 2012-08-30 20:17:48]

https://chromiumcodereview.appspot.com/10911014/diff/4001/testing/test_env.py
File testing/test_env.py (right):

https://chromiumcodereview.appspot.com/10911014/diff/4001/testing/test_env.py...
testing/test_env.py:41: chrome_sandbox_path = CHROME_SANDBOX_PATH
On 2012/08/30 19:43:17, Marc-Antoine Ruel wrote:
> 1 line:
> chrome_sandbox_path = env.get(CHROME_SANDBOX_ENV, CHROME_SANDBOX_PATH)

Done.

https://chromiumcodereview.appspot.com/10911014/diff/4001/testing/test_env.py...
testing/test_env.py:44: print 'Enabling sandbox. Setting environment variable:'
On 2012/08/30 19:43:17, Marc-Antoine Ruel wrote:
> I'd prefer no output except for errors. At worst, some off-by-default logging.

Hidden behind a verbose flag

https://chromiumcodereview.appspot.com/10911014/diff/4001/testing/xvfb.py
File testing/xvfb.py (right):

https://chromiumcodereview.appspot.com/10911014/diff/4001/testing/xvfb.py#new...
testing/xvfb.py:116: print >> sys.stderr, 'Failed to run %s' % ' '.join(ice_cmd)
On 2012/08/30 19:43:17, Marc-Antoine Ruel wrote:
> Argh. Thanks!

No problem, I think I was the one who introduced this.

[commit-bot: I haz the power, 2012-08-30 20:19:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/csharp@chromium.org/10911014/1004

[commit-bot: I haz the power, 2012-08-30 22:48:19]

Change committed as 154297