Enable Chrome Sandbox with run_test_cases.py

tools/isolate/run_test_cases.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Runs each test cases as a single shard, single process execution.
 
 Similar to sharding_supervisor.py but finer grained. Runs multiple instances in
 parallel.
 """
 
 import fnmatch
 import json
 import logging
 import optparse
 import os
 import Queue
 import subprocess
+import stat
 import sys
 import threading
 import time
 
 
 # These are known to influence the way the output is generated.
 KNOWN_GTEST_ENV_VARS = [
   'GTEST_ALSO_RUN_DISABLED_TESTS',
   'GTEST_BREAK_ON_FAILURE',
   'GTEST_CATCH_EXCEPTIONS',
@@ skipping 20 matching lines @@
   # TODO(maruel): Handle.
   'GTEST_RANDOM_SEED',
   # TODO(maruel): Handle.
   'GTEST_REPEAT',
   'GTEST_SHARD_INDEX',
   # TODO(maruel): Handle.
   'GTEST_SHUFFLE',
   'GTEST_TOTAL_SHARDS',
 ]
 
+CHROME_SANDBOX_ENV = 'CHROME_DEVEL_SANDBOX'
+CHROME_SANDBOX_PATH = '/opt/chromium/chrome_sandbox'
+
+
+def should_enable_sandbox(sandbox_path):
+  """Return a boolean indicating that the current slave is capable of using the
+  sandbox and should enable it.  This should return True iff the slave is a
+  Linux host with the sandbox file present and configured correctly."""
+  if not (sys.platform.startswith('linux') and
+          os.path.exists(sandbox_path)):
+    return False
+  sandbox_stat = os.stat(sandbox_path)
+  if ((sandbox_stat.st_mode & stat.S_ISUID) and
+      (sandbox_stat.st_mode & stat.S_IRUSR) and
+      (sandbox_stat.st_mode & stat.S_IXUSR) and
+      (sandbox_stat.st_uid == 0)):
+    return True
+  return False
 
 def num_processors():
   """Returns the number of processors.
 
   Python on OSX 10.6 raises a NotImplementedError exception.
   """
   try:
     # Multiprocessing
     import multiprocessing
     return multiprocessing.cpu_count()
@@ skipping 485 matching lines @@
     self.executable = executable
     self.cwd_dir = cwd_dir
     self.timeout = timeout
     self.progress = progress
     self.retry_count = retry_count
     # It is important to remove the shard environment variables since it could
     # conflict with --gtest_filter.
     self.env = setup_gtest_env()
     self.decider = decider
 
+    # Setup the chrome sandbox, using the default path if no path is specified.

[M-A Ruel, 2012/08/30 18:47:37]

This code doesn't belong here, run_test_cases.py is mostly gtest specific and
_not_ chromium specific. This code belong in testing/test_env.py or a new script
called by it. That would mean updating the relevant .isolate files. This would
probably make sense since base_unittests probably doesn't need the sandbox.

+    if CHROME_SANDBOX_ENV in self.env:
+      chrome_sandbox_path = self.env[CHROME_SANDBOX_ENV]
+    else:
+      chrome_sandbox_path = CHROME_SANDBOX_PATH
+
+    if should_enable_sandbox(chrome_sandbox_path):
+      print 'Enabling sandbox. Setting environment variable:'
+      print '  %s="%s"' % (CHROME_SANDBOX_ENV, chrome_sandbox_path)
+      self.env[CHROME_SANDBOX_ENV] = chrome_sandbox_path
+    else:
+      print 'Disabling sandbox. Setting environment variable:'
+      print '  %s=""' % CHROME_SANDBOX_ENV
+      self.env[CHROME_SANDBOX_ENV] = ''
+
   def map(self, test_case):
     """Traces a single test case and returns its output."""
     cmd = [self.executable, '--gtest_filter=%s' % test_case]
     cmd = fix_python_path(cmd)
     out = []
     for retry in range(self.retry_count):
       if self.decider.should_stop():
         break
 
       start = time.time()
@@ skipping 291 matching lines @@
       executable,
       test_cases,
       options.jobs,
       options.timeout,
       options.run_all,
       result_file)
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv[1:]))