lib/compiler/implementation/enqueue.dart - Issue 10911006: Collect the types used in is-checks in the resolver phase.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/enqueue.dart

Issue 10911006: Collect the types used in is-checks in the resolver phase. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Fix last upload. Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « lib/compiler/implementation/compiler.dart ('k') | lib/compiler/implementation/js_backend/emitter.dart » ('j') | lib/compiler/implementation/resolver.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: lib/compiler/implementation/enqueue.dart

diff --git a/lib/compiler/implementation/enqueue.dart b/lib/compiler/implementation/enqueue.dart

index 07b54f43927536b239f6cbbff7dd9ce1c87db213..a4e0143042fa9bbc6d5db576fdc34747fa80e820 100644

--- a/lib/compiler/implementation/enqueue.dart

+++ b/lib/compiler/implementation/enqueue.dart

@@ -174,7 +174,7 @@ class Enqueuer {

universe.instantiatedClassInstanceFields.add(member.name);

if (compiler.enableTypeAssertions) {

DartType type = member.computeType(compiler);

- registerIsCheck(type.element);

+ registerIsCheck(type);

SourceString helper = compiler.backend.getCheckedModeHelper(type);

if (helper != null) {

Element helperElement = compiler.findHelper(helper);

@@ -348,9 +348,8 @@ class Enqueuer {

});

}

- // TODO(ngeoffray): This should get a type.

- void registerIsCheck(Element element) {

- universe.isChecks.add(element);

+ void registerIsCheck(DartType type) {

+ universe.isChecks.add(type);

}

void forEach(f(WorkItem work)) {