Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Unified Diff: lib/compiler/implementation/compiler.dart

Issue 10911006: Collect the types used in is-checks in the resolver phase. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix last upload. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/compiler/implementation/enqueue.dart » ('j') | lib/compiler/implementation/resolver.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/compiler.dart
diff --git a/lib/compiler/implementation/compiler.dart b/lib/compiler/implementation/compiler.dart
index 1b68df8719f13412a70e87a49c951672b67cbc8f..c8d62eab52bf38ee5c8f93701b9a4e39ab7144fe 100644
--- a/lib/compiler/implementation/compiler.dart
+++ b/lib/compiler/implementation/compiler.dart
@@ -371,9 +371,6 @@ class Compiler implements DiagnosticListener {
assertMethod = coreLibrary.find(const SourceString('assert'));
initializeSpecialClasses();
-
- //patchDartLibrary(coreLibrary, 'core');
- //patchDartLibrary(coreImplLibrary, 'coreimpl');
}
void importCoreLibrary(LibraryElement library) {
@@ -576,6 +573,11 @@ class Compiler implements DiagnosticListener {
if (compilationFailed) return;
+ // TODO(karlklose): also take the instantiated types into account and move
+ // this computation to before codegen.
+ enqueuer.codegen.universe.computeRequiredTypes(
+ enqueuer.resolution.universe.isChecks);
+
backend.assembleProgram();
checkQueues();
« no previous file with comments | « no previous file | lib/compiler/implementation/enqueue.dart » ('j') | lib/compiler/implementation/resolver.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698