Remove android_test trybot type

Remove android_test trybot type

Also:
- renaming android_dbg trybot type in
  prep for switch to using this in presubmit.py
- creating new split builder trybot type.  This will let
  us test changes that are only covered by the extended
  tests on the fyi bot.

BUG=147462
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156368

[M-A Ruel, 2012-09-12 13:01:26]

I'd rather see testfilter with non-default tests than yet another builder.

https://chromiumcodereview.appspot.com/10910219/diff/6/masters/master.tryserv...
File masters/master.tryserver.chromium/master.cfg (right):

https://chromiumcodereview.appspot.com/10910219/diff/6/masters/master.tryserv...
masters/master.tryserver.chromium/master.cfg:728: b_android_dbg_tester =
CreateBuilder(
I prefer the variable to be the name of the builder.
b_android_dbg_triggered_tests

https://chromiumcodereview.appspot.com/10910219/diff/6/masters/master.tryserv...
masters/master.tryserver.chromium/master.cfg:737: b_android_fyi_dbg =
CreateBuilder(
What's different on fyi? Can't this be achieved with testfilter?

[Isaac (away), 2012-09-12 16:56:41]

On 2012/09/12 13:01:26, Marc-Antoine Ruel wrote:
> I'd rather see testfilter with non-default tests than yet another builder.

Noted.  I think it is worth having two separate trybot types for android,
though.  There are steps the fyi bot runs that are not tests (like 'check
webview licenses').

The plan of action is to delete the 'android' trybot target one I switch CQ /
presubmit.py to the android_dbg target.

What do you think of using the word triggered in the name?  I also send out a
rietveld CL which will exclude bots with 'triggered' in their name from the try
more bots ui.  rogerta thought maybe it would be sufficient to call this
'android_dbg_tests' and use the word 'tests' in for the rietveld decision.

[Isaac (away), 2012-09-12 16:56:49]

https://chromiumcodereview.appspot.com/10910219/diff/6/masters/master.tryserv...
File masters/master.tryserver.chromium/master.cfg (right):

https://chromiumcodereview.appspot.com/10910219/diff/6/masters/master.tryserv...
masters/master.tryserver.chromium/master.cfg:737: b_android_fyi_dbg =
CreateBuilder(
On 2012/09/12 13:01:26, Marc-Antoine Ruel wrote:
> What's different on fyi? Can't this be achieved with testfilter?

It will build additional targets on the builder side and run more time consuming
tests on the tester side.  It will mirror our fyi bots while the other one will
mirror our main builders.

[M-A Ruel, 2012-09-12 17:01:23]

On 2012/09/12 16:56:41, Isaac wrote:
> On 2012/09/12 13:01:26, Marc-Antoine Ruel wrote:
> > I'd rather see testfilter with non-default tests than yet another builder.
> 
> Noted.  I think it is worth having two separate trybot types for android,
> though.  There are steps the fyi bot runs that are not tests (like 'check
> webview licenses').

From an infrastructure perspective, 'check webview licenses' is a test like any
other build step that 'tests' the checked in code is good. Please keep that in
perspective.

> The plan of action is to delete the 'android' trybot target one I switch CQ /
> presubmit.py to the android_dbg target.
> 
> What do you think of using the word triggered in the name?

I'm fine with that. It's a dead-simple way to announce it. I like dead-simple
solutions. :)

> I also send out a
> rietveld CL which will exclude bots with 'triggered' in their name from the
try
> more bots ui.  rogerta thought maybe it would be sufficient to call this
> 'android_dbg_tests' and use the word 'tests' in for the rietveld decision.

'tests' is not as obvious as 'triggered'. So I prefer the dead-obvious wording.

What's the cost of "building more" in FYI vs the non-FYI builder?

lgtm

[cmp, 2012-09-12 20:14:58]

lgtm with maruel's lgtm :)

[Isaac (away), 2012-09-12 20:35:14]

On 2012/09/12 17:01:23, Marc-Antoine Ruel wrote:
> On 2012/09/12 16:56:41, Isaac wrote:
> > On 2012/09/12 13:01:26, Marc-Antoine Ruel wrote:
> > > I'd rather see testfilter with non-default tests than yet another builder.
> > 
> > Noted.  I think it is worth having two separate trybot types for android,
> > though.  There are steps the fyi bot runs that are not tests (like 'check
> > webview licenses').
> 
> From an infrastructure perspective, 'check webview licenses' is a test like
any
> other build step that 'tests' the checked in code is good. Please keep that in
> perspective.
> 
> > The plan of action is to delete the 'android' trybot target one I switch CQ
/
> > presubmit.py to the android_dbg target.
> > 
> > What do you think of using the word triggered in the name?
> 
> I'm fine with that. It's a dead-simple way to announce it. I like dead-simple
> solutions. :)
> 
> > I also send out a
> > rietveld CL which will exclude bots with 'triggered' in their name from the
> try
> > more bots ui.  rogerta thought maybe it would be sufficient to call this
> > 'android_dbg_tests' and use the word 'tests' in for the rietveld decision.
> 
> 'tests' is not as obvious as 'triggered'. So I prefer the dead-obvious
wording.
> 
> What's the cost of "building more" in FYI vs the non-FYI builder?

More confusing status that have failed build targets that we are expecting to
fail.  More time for trybot cycle.  Possibly other thigns as we continue to add
additional stuff on fyi bots.

[Isaac (away), 2012-09-12 20:35:46]

Made the variable changes, committing.

[commit-bot: I haz the power, 2012-09-12 20:36:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ilevy@chromium.org/10910219/1002

[commit-bot: I haz the power, 2012-09-12 20:36:53]

Change committed as 156368