Enable hidpi favicons for favicons history does not know about

Enable hidpi favicons for favicons history does not know about.

Bug=130896, 147713
Test=Run chrome in HiDPI mode with a new --user-data-dir
     Favicons should show up in hidpi for sites which have hidpi favicons.
     Favicons should stay hidpi after sync updates. (I tested this by changing the title of the bookmark of "amazon.com")

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156478

[pkotwicz, 2012-09-11 23:28:17]

This CL enables HiDPI favicons for new favicons.
It adds FaviconService::SetFavicons() and FaviconService::MergeFavicon().

Favicons which are resized to the size that they will be displayed in the UI are
stored in the database. However, only the 16x16 favicon is synced.

Scott, can you look at the patch as a whole?
Nicolas, can you review the sync aspects?

[sky, 2012-09-12 03:16:18]

LGTM

http://codereview.chromium.org/10910212/diff/8001/chrome/browser/favicon/favi...
File chrome/browser/favicon/favicon_service.cc (right):

http://codereview.chromium.org/10910212/diff/8001/chrome/browser/favicon/favi...
chrome/browser/favicon/favicon_service.cc:210: if (history_service_) {
nit: early return if no hs

[Nicolas Zea, 2012-09-12 23:13:20]

sync LGTM with a comment nit

http://codereview.chromium.org/10910212/diff/4003/chrome/browser/sync/glue/bo...
File chrome/browser/sync/glue/bookmark_change_processor.cc (right):

http://codereview.chromium.org/10910212/diff/4003/chrome/browser/sync/glue/bo...
chrome/browser/sync/glue/bookmark_change_processor.cc:640: // gfx::kFaviconSize
in width and height, use gfx::kFaviconSize as a guess of
I think it's simpler to just say
"Sync favicons are always in gfx::kFaviconSize in width and height. Store it
into the favicon service as such"
and maybe move this down to right above the actual MergeFavicon call.

[commit-bot: I haz the power, 2012-09-13 00:46:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10910212/9011

[commit-bot: I haz the power, 2012-09-13 02:46:55]

Change committed as 156478