Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1057)

Unified Diff: chrome/browser/favicon/favicon_tab_helper.cc

Issue 10910212: Enable hidpi favicons for favicons history does not know about (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/favicon/favicon_service.cc ('k') | chrome/browser/instant/instant_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/favicon/favicon_tab_helper.cc
diff --git a/chrome/browser/favicon/favicon_tab_helper.cc b/chrome/browser/favicon/favicon_tab_helper.cc
index ff5505ecab4550d0f1f65ae3f25f87842fe5c7fc..c317dabc575a277bccef32730dd2bca1bf994295 100644
--- a/chrome/browser/favicon/favicon_tab_helper.cc
+++ b/chrome/browser/favicon/favicon_tab_helper.cc
@@ -113,12 +113,8 @@ void FaviconTabHelper::SaveFavicon() {
favicon.image.IsEmpty()) {
return;
}
- std::vector<unsigned char> image_data;
- // TODO: Save all representations.
- gfx::PNGCodec::EncodeBGRASkBitmap(
- favicon.image.AsBitmap(), false, &image_data);
- service->SetFavicon(
- entry->GetURL(), favicon.url, image_data, history::FAVICON);
+ service->SetFavicons(entry->GetURL(), favicon.url, history::FAVICON,
+ favicon.image);
}
int FaviconTabHelper::DownloadImage(const GURL& image_url,
« no previous file with comments | « chrome/browser/favicon/favicon_service.cc ('k') | chrome/browser/instant/instant_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698