Extensions Docs Server: Fix 404s from API links on the samples page

Extensions Docs Server: Fix 404s from API links on the samples page

Some links to APIs were giving 404s from the samples page. This was because
names of APIs like app.window were being split up wrong. The samples page will
now only have links to valid pages.

BUG=146975
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=156707

[not at google - send to devlin, 2012-09-11 23:40:00]

neat. it would be nice to test it though.

http://codereview.chromium.org/10910208/diff/1/chrome/common/extensions/docs/...
File chrome/common/extensions/docs/server2/samples_data_source.py (right):

http://codereview.chromium.org/10910208/diff/1/chrome/common/extensions/docs/...
chrome/common/extensions/docs/server2/samples_data_source.py:53: def
_MakeAPIList(self):
_GetAllAPINames?

we're going to be calculating it a lot though; for each link on the samples
page. that's unnecessary. perhaps pass it in as an argument to _MakeApiLink and
calculate it once from _MakeSamplesList?

http://codereview.chromium.org/10910208/diff/1/chrome/common/extensions/docs/...
chrome/common/extensions/docs/server2/samples_data_source.py:129: continue
You might also want to add hasListener for completeness:

http://developer.chrome.com/extensions/events.html

p.s. that page has broken anchors. we should fix that.

http://codereview.chromium.org/10910208/diff/1/chrome/common/extensions/docs/...
chrome/common/extensions/docs/server2/samples_data_source.py:140: link =
self._MakeAPILink('method', item)
TODO(cduvall): this might be a property.

[cduvall, 2012-09-12 21:59:05]

https://chromiumcodereview.appspot.com/10910208/diff/1/chrome/common/extensio...
File chrome/common/extensions/docs/server2/samples_data_source.py (right):

https://chromiumcodereview.appspot.com/10910208/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/samples_data_source.py:53: def
_MakeAPIList(self):
On 2012/09/11 23:40:00, kalman wrote:
> _GetAllAPINames?
> 
> we're going to be calculating it a lot though; for each link on the samples
> page. that's unnecessary. perhaps pass it in as an argument to _MakeApiLink
and
> calculate it once from _MakeSamplesList?

Done.

https://chromiumcodereview.appspot.com/10910208/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/samples_data_source.py:129: continue
On 2012/09/11 23:40:00, kalman wrote:
> You might also want to add hasListener for completeness:
> 
> http://developer.chrome.com/extensions/events.html
> 
> p.s. that page has broken anchors. we should fix that.

Done.

https://chromiumcodereview.appspot.com/10910208/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/samples_data_source.py:140: link =
self._MakeAPILink('method', item)
On 2012/09/11 23:40:00, kalman wrote:
> TODO(cduvall): this might be a property.

Done.

[not at google - send to devlin, 2012-09-14 00:47:19]

lgtm

http://codereview.chromium.org/10910208/diff/1/chrome/common/extensions/docs/...
File chrome/common/extensions/docs/server2/samples_data_source.py (right):

http://codereview.chromium.org/10910208/diff/1/chrome/common/extensions/docs/...
chrome/common/extensions/docs/server2/samples_data_source.py:140: link =
self._MakeAPILink('method', item)
On 2012/09/12 21:59:05, cduvall wrote:
> On 2012/09/11 23:40:00, kalman wrote:
> > TODO(cduvall): this might be a property.
> 
> Done.

or a type (sorry)

http://codereview.chromium.org/10910208/diff/5001/chrome/common/extensions/do...
File chrome/common/extensions/docs/server2/handler.py (right):

http://codereview.chromium.org/10910208/diff/5001/chrome/common/extensions/do...
chrome/common/extensions/docs/server2/handler.py:334:
self.response.set_status(404)
could we actually show the real 404 page? figure out a way to share code with
the other place we show the 404?

p.s. i wonder if this will be automatically fixed by your other change
(http://codereview.chromium.org/10911301/) anyway

http://codereview.chromium.org/10910208/diff/5001/chrome/common/extensions/do...
File chrome/common/extensions/docs/server2/samples_data_source.py (right):

http://codereview.chromium.org/10910208/diff/5001/chrome/common/extensions/do...
chrome/common/extensions/docs/server2/samples_data_source.py:129: api_list =
self._GetAllAPINames()
put this right at the top of _MakeSamplesList, it doesn't need to be calculated
for each file and api item

[cduvall, 2012-09-14 01:10:28]

https://chromiumcodereview.appspot.com/10910208/diff/1/chrome/common/extensio...
File chrome/common/extensions/docs/server2/samples_data_source.py (right):

https://chromiumcodereview.appspot.com/10910208/diff/1/chrome/common/extensio...
chrome/common/extensions/docs/server2/samples_data_source.py:140: link =
self._MakeAPILink('method', item)
On 2012/09/14 00:47:19, kalman wrote:
> On 2012/09/12 21:59:05, cduvall wrote:
> > On 2012/09/11 23:40:00, kalman wrote:
> > > TODO(cduvall): this might be a property.
> > 
> > Done.
> 
> or a type (sorry)

Done.

https://chromiumcodereview.appspot.com/10910208/diff/5001/chrome/common/exten...
File chrome/common/extensions/docs/server2/handler.py (right):

https://chromiumcodereview.appspot.com/10910208/diff/5001/chrome/common/exten...
chrome/common/extensions/docs/server2/handler.py:334:
self.response.set_status(404)
On 2012/09/14 00:47:20, kalman wrote:
> could we actually show the real 404 page? figure out a way to share code with
> the other place we show the 404?
> 
> p.s. i wonder if this will be automatically fixed by your other change
> (http://codereview.chromium.org/10911301/) anyway

Done.

https://chromiumcodereview.appspot.com/10910208/diff/5001/chrome/common/exten...
File chrome/common/extensions/docs/server2/samples_data_source.py (right):

https://chromiumcodereview.appspot.com/10910208/diff/5001/chrome/common/exten...
chrome/common/extensions/docs/server2/samples_data_source.py:129: api_list =
self._GetAllAPINames()
On 2012/09/14 00:47:20, kalman wrote:
> put this right at the top of _MakeSamplesList, it doesn't need to be
calculated
> for each file and api item

Done. Oops that was dumb.