Issue 10910112: Correctly inject titlebars into windows whose first element isn't <html>

Issue 10910112: Correctly inject titlebars into windows whose first element isn't <html> (Closed)

Created:
8 years, 3 months ago by jeremya

Modified:
8 years, 3 months ago

Reviewers:
Mihai Parparita -not on Chrome

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, darin-cc_chromium.org, benwells

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

Correctly inject titlebars into windows whose first element isn't <html> document.childNodes[0] --> document.documentElement R=mihaip@chromium.org BUG=146780 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=155231

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/renderer/resources/extensions/inject_app_titlebar.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 8 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremya@chromium.org/10910112/1

8 years, 3 months ago (2012-09-06 17:34:38 UTC) #4

commit-bot: I haz the power

Try job failure for 10910112-1 (retry) on win_rel for step "runhooks". It's a second try, ...

8 years, 3 months ago (2012-09-06 19:33:59 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremya@chromium.org/10910112/1

8 years, 3 months ago (2012-09-06 19:35:03 UTC) #6

Mihai Parparita -not on Chrome

sync_integration_tests flaked for me earlier today. Might as well dcommit this? Mihai On Thu, Sep ...

8 years, 3 months ago (2012-09-06 19:39:52 UTC) #7

done.