chrome/renderer/resources/extensions/inject_app_titlebar.js - Issue 10910112: Correctly inject titlebars into windows whose first element isn't <html>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/inject_app_titlebar.js

Issue 10910112: Correctly inject titlebars into windows whose first element isn't <html> (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/resources/extensions/inject_app_titlebar.js

diff --git a/chrome/renderer/resources/extensions/inject_app_titlebar.js b/chrome/renderer/resources/extensions/inject_app_titlebar.js

index 69d6ff5a603f248681eb5b2c0d15c4059e135c71..4b32769a0c5e155a98b4c660d35f4cefd7b76786 100644

--- a/chrome/renderer/resources/extensions/inject_app_titlebar.js

+++ b/chrome/renderer/resources/extensions/inject_app_titlebar.js

@@ -3,7 +3,7 @@

// found in the LICENSE file.

exports.didCreateDocumentElement = function() {

- var root = new WebKitShadowRoot(document.childNodes[0]);

+ var root = new WebKitShadowRoot(document.documentElement);

root.appendChild(document.createElement('style')).innerText =

// TODO(jeremya): switch this to use automatic inlining once grit

// supports inlining into JS. See http://crbug.com/146319.

« no previous file with comments | « no previous file | no next file » | no next file with comments »