Issue 10910034: Attempt 2 at: Fixes crash that occured because NativeViewHostAura::Detach was not

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10910034: Attempt 2 at: Fixes crash that occured because NativeViewHostAura::Detach was not (Closed)

Created:
8 years, 3 months ago by sky

Modified:
8 years, 3 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, tfarina, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Attempt 2 at: Fixes crash that occured because NativeViewHostAura::Detach was not changing the parent of the attached window. This meant that if the parent was destroyed the attached window would be destroyed. Fix for windows was done here: https://chromiumcodereview.appspot.com/10832011 This differs from first patch in that I needed to add checks for RootWindow in a couple of places. BUG=132090, 141870 TEST=see bug R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154477

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -25 lines)			Patch
M	chrome/browser/ui/views/constrained_window_views.cc	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_aura.cc	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
M	ui/views/controls/native/native_view_host.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	ui/views/controls/native/native_view_host.cc	View		1 chunk	+17 lines, -0 lines	0 comments	Download
M	ui/views/controls/native/native_view_host_aura.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	ui/views/controls/native/native_view_host_win.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	ui/views/controls/native/native_view_host_win.cc	View		2 chunks	+0 lines, -15 lines	0 comments	Download
M	ui/views/widget/native_widget_aura.cc	View	1	2 chunks	+6 lines, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

lgtm