Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 10832011: Makes NativeViewHostWin change the parent of the hwnd when (Closed)

Created:
8 years, 5 months ago by sky
Modified:
8 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, tfarina, jam, dcheng, darin-cc_chromium.org
Visibility:
Public.

Description

Makes NativeViewHostWin change the parent of the hwnd when detaching. Without this the hwnd would remain parented so that if the widget containing the NativeViewHost was destroyed then the hwnd would get destroyed by virtue of being a child. Previously we had this logic in NativeTabContentsViewWin (lost in WebView refactoring), but it seems better to promote to NativeViewHostWin. BUG=132090 TEST=none R=ben@chromium.org,jam@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149459

Patch Set 1 #

Patch Set 2 : Remove tab change #

Patch Set 3 : Fix focus issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -41 lines) Patch
M content/browser/web_contents/web_contents_view_win.cc View 3 chunks +2 lines, -38 lines 0 comments Download
A ui/base/win/hidden_window.h View 1 chunk +20 lines, -0 lines 0 comments Download
A ui/base/win/hidden_window.cc View 1 chunk +56 lines, -0 lines 0 comments Download
M ui/ui.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/controls/native/native_view_host_win.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M ui/views/controls/native/native_view_host_win.cc View 1 2 3 chunks +22 lines, -2 lines 0 comments Download
M ui/views/focus/focus_manager.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
sky
8 years, 5 months ago (2012-07-25 16:57:03 UTC) #1
jam
lgtm
8 years, 5 months ago (2012-07-25 17:02:16 UTC) #2
Ben Goodger (Google)
I suck and that's sad, sorry for taking so long. LGTM
8 years, 4 months ago (2012-07-27 17:21:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/10832011/2001
8 years, 4 months ago (2012-07-28 02:01:59 UTC) #4
commit-bot: I haz the power
Try job failure for 10832011-2001 (retry) on win_rel for steps "interactive_ui_tests, browser_tests". It's a second ...
8 years, 4 months ago (2012-07-28 04:52:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/10832011/2001
8 years, 4 months ago (2012-07-31 15:58:15 UTC) #6
commit-bot: I haz the power
Try job failure for 10832011-2001 (retry) on win_rel for steps "interactive_ui_tests, browser_tests". It's a second ...
8 years, 4 months ago (2012-07-31 19:20:46 UTC) #7
sky
I ran into a crash with the first version of this patch. The crash would ...
8 years, 4 months ago (2012-08-01 17:18:12 UTC) #8
Ben Goodger (Google)
lgtm
8 years, 4 months ago (2012-08-01 17:21:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/10832011/11002
8 years, 4 months ago (2012-08-01 17:44:40 UTC) #10
commit-bot: I haz the power
8 years, 4 months ago (2012-08-01 19:24:03 UTC) #11
Change committed as 149459

Powered by Google App Engine
This is Rietveld 408576698