chrome/browser/extensions/extension_tab_util_android.cc - Issue 10909256: Always send the full tab object in ExtensionAction click event.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_tab_util_android.cc

Issue 10909256: Always send the full tab object in ExtensionAction click event. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Realized that any API outside of tabs.json and windows.json that referenced tabs.Tab would have sam… Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_tab_util_android.cc

diff --git a/chrome/browser/extensions/extension_tab_util_android.cc b/chrome/browser/extensions/extension_tab_util_android.cc

index 2e0b51a98ca8dbe6ba429f746f1dcb356760e558..786ddfd18d2c21bbc93dbc8888a0f3b0f595be76 100644

--- a/chrome/browser/extensions/extension_tab_util_android.cc

+++ b/chrome/browser/extensions/extension_tab_util_android.cc

@@ -55,10 +55,11 @@ DictionaryValue* ExtensionTabUtil::CreateTabValue(

return NULL;

}

-DictionaryValue* ExtensionTabUtil::CreateTabValueActive(

+DictionaryValue* ExtensionTabUtil::CreateTabValue(

const WebContents* contents,

- bool active,

- const extensions::Extension* extension) {

+ TabStripModel* tab_strip,

+ int tab_index,

+ IncludePrivacySensitiveFields include_privacy_sensitive_fields) {

NOTIMPLEMENTED();

return NULL;

}