Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: chrome/browser/extensions/extension_tab_util_android.cc

Issue 10909256: Always send the full tab object in ExtensionAction click event. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Realized that any API outside of tabs.json and windows.json that referenced tabs.Tab would have sam… Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/extension_tab_util.h" 5 #include "chrome/browser/extensions/extension_tab_util.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "googleurl/src/gurl.h" 8 #include "googleurl/src/gurl.h"
9 9
10 using base::DictionaryValue; 10 using base::DictionaryValue;
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 48
49 DictionaryValue* ExtensionTabUtil::CreateTabValue( 49 DictionaryValue* ExtensionTabUtil::CreateTabValue(
50 const WebContents* contents, 50 const WebContents* contents,
51 TabStripModel* tab_strip, 51 TabStripModel* tab_strip,
52 int tab_index, 52 int tab_index,
53 const extensions::Extension* extension) { 53 const extensions::Extension* extension) {
54 NOTIMPLEMENTED(); 54 NOTIMPLEMENTED();
55 return NULL; 55 return NULL;
56 } 56 }
57 57
58 DictionaryValue* ExtensionTabUtil::CreateTabValueActive( 58 DictionaryValue* ExtensionTabUtil::CreateTabValue(
59 const WebContents* contents, 59 const WebContents* contents,
60 bool active, 60 TabStripModel* tab_strip,
61 const extensions::Extension* extension) { 61 int tab_index,
62 IncludePrivacySensitiveFields include_privacy_sensitive_fields) {
62 NOTIMPLEMENTED(); 63 NOTIMPLEMENTED();
63 return NULL; 64 return NULL;
64 } 65 }
65 66
66 bool ExtensionTabUtil::GetTabStripModel(const WebContents* web_contents, 67 bool ExtensionTabUtil::GetTabStripModel(const WebContents* web_contents,
67 TabStripModel** tab_strip_model, 68 TabStripModel** tab_strip_model,
68 int* tab_index) { 69 int* tab_index) {
69 NOTIMPLEMENTED(); 70 NOTIMPLEMENTED();
70 return false; 71 return false;
71 } 72 }
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 const base::Callback<void(WebContents*)>& callback) { 113 const base::Callback<void(WebContents*)>& callback) {
113 NOTIMPLEMENTED(); 114 NOTIMPLEMENTED();
114 } 115 }
115 116
116 // static 117 // static
117 extensions::WindowController* ExtensionTabUtil::GetWindowControllerOfTab( 118 extensions::WindowController* ExtensionTabUtil::GetWindowControllerOfTab(
118 const WebContents* web_contents) { 119 const WebContents* web_contents) {
119 NOTIMPLEMENTED(); 120 NOTIMPLEMENTED();
120 return NULL; 121 return NULL;
121 } 122 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698