Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Unified Diff: chrome/browser/extensions/menu_manager.cc

Issue 10909256: Always send the full tab object in ExtensionAction click event. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: kalments Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/menu_manager.cc
diff --git a/chrome/browser/extensions/menu_manager.cc b/chrome/browser/extensions/menu_manager.cc
index bd2e0eb7b45a93351599f729f37c2c092967f092..33fcb08ab6503daa43d0b94801be2c697565f3e3 100644
--- a/chrome/browser/extensions/menu_manager.cc
+++ b/chrome/browser/extensions/menu_manager.cc
@@ -643,10 +643,12 @@ void MenuManager::ExecuteCommand(Profile* profile,
// No tab info in a platform app.
if (!extension || !extension->is_platform_app()) {
// Note: web_contents are NULL in unit tests :(
- if (web_contents)
- args->Append(ExtensionTabUtil::CreateTabValue(web_contents, extension));
- else
+ if (web_contents) {
+ args->Append(ExtensionTabUtil::CreateTabValue(
+ web_contents, ExtensionTabUtil::INCLUDE_PRIVACY_SENSITIVE_FIELDS));
+ } else {
args->Append(new DictionaryValue());
+ }
}
if (item->type() == MenuItem::CHECKBOX ||

Powered by Google App Engine
This is Rietveld 408576698