Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1566)

Unified Diff: chrome/browser/extensions/extension_tab_util_android.cc

Issue 10909256: Always send the full tab object in ExtensionAction click event. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: kalments Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_tab_util.cc ('k') | chrome/browser/extensions/menu_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_tab_util_android.cc
diff --git a/chrome/browser/extensions/extension_tab_util_android.cc b/chrome/browser/extensions/extension_tab_util_android.cc
index 2e0b51a98ca8dbe6ba429f746f1dcb356760e558..7cd8377417b0a3cac6e1c918ff5ed1091580494b 100644
--- a/chrome/browser/extensions/extension_tab_util_android.cc
+++ b/chrome/browser/extensions/extension_tab_util_android.cc
@@ -34,6 +34,8 @@ int ExtensionTabUtil::GetWindowIdOfTab(const WebContents* web_contents) {
DictionaryValue* ExtensionTabUtil::CreateTabValue(
const WebContents* contents,
+ TabStripModel* tab_strip,
+ int tab_index,
const extensions::Extension* extension) {
NOTIMPLEMENTED();
return NULL;
@@ -50,15 +52,7 @@ DictionaryValue* ExtensionTabUtil::CreateTabValue(
const WebContents* contents,
TabStripModel* tab_strip,
int tab_index,
- const extensions::Extension* extension) {
- NOTIMPLEMENTED();
- return NULL;
-}
-
-DictionaryValue* ExtensionTabUtil::CreateTabValueActive(
- const WebContents* contents,
- bool active,
- const extensions::Extension* extension) {
+ IncludePrivacySensitiveFields include_privacy_sensitive_fields) {
NOTIMPLEMENTED();
return NULL;
}
« no previous file with comments | « chrome/browser/extensions/extension_tab_util.cc ('k') | chrome/browser/extensions/menu_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698