Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 10909143: Revert 155574 - [Chromoting] Refactoring DesktopEnvironment and moving screen/audio recorders to Cl… (Closed)

Created:
8 years, 3 months ago by alexeypa (please no reviews)
Modified:
8 years, 3 months ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Revert 155574 - [Chromoting] Refactoring DesktopEnvironment and moving screen/audio recorders to ClientSession. This CL changes the way screen/audio recorders and event executors are managed. New DesktopEnvironmentFactory class is now used by ChromotingHost's owner to specify the kind of desktop environment (or virtual terminal) to be used by the host. Screen/audio recorders and event executors now owned by the ClientSession instance, so there is a separate set of recorders and stubs exists for each authenticated client session. Clients sessions can now be torn dowsn in parallel with the host shuttting down. This is the 2nd attempt to land this change. This version includes: - |ClientSession| objects are torn down asynchronously now. - |ChromotingHost| now waits until all connections are torn down before deleting the session manager. BUG=134694 TEST=remoting_unittests Review URL: https://chromiumcodereview.appspot.com/10911152 TBR=alexeypa@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=155616

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+449 lines, -933 lines) Patch
M remoting/host/chromoting_host.h View 6 chunks +34 lines, -14 lines 0 comments Download
M remoting/host/chromoting_host.cc View 9 chunks +129 lines, -28 lines 0 comments Download
M remoting/host/chromoting_host_unittest.cc View 9 chunks +25 lines, -49 lines 0 comments Download
M remoting/host/client_session.h View 6 chunks +14 lines, -56 lines 0 comments Download
M remoting/host/client_session.cc View 8 chunks +11 lines, -140 lines 0 comments Download
M remoting/host/client_session_unittest.cc View 10 chunks +27 lines, -89 lines 0 comments Download
M remoting/host/desktop_environment.h View 2 chunks +32 lines, -11 lines 0 comments Download
M remoting/host/desktop_environment.cc View 1 chunk +78 lines, -10 lines 0 comments Download
D remoting/host/desktop_environment_factory.h View 1 chunk +0 lines, -34 lines 0 comments Download
D remoting/host/desktop_environment_factory.cc View 1 chunk +0 lines, -42 lines 0 comments Download
M remoting/host/event_executor.h View 1 chunk +3 lines, -3 lines 0 comments Download
D remoting/host/event_executor_fake.h View 1 chunk +0 lines, -36 lines 0 comments Download
D remoting/host/event_executor_fake.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M remoting/host/event_executor_linux.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M remoting/host/event_executor_mac.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M remoting/host/event_executor_win.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M remoting/host/host_mock_objects.h View 1 chunk +3 lines, -4 lines 0 comments Download
M remoting/host/host_mock_objects.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M remoting/host/plugin/host_script_object.h View 3 chunks +8 lines, -6 lines 0 comments Download
M remoting/host/plugin/host_script_object.cc View 7 chunks +36 lines, -8 lines 0 comments Download
M remoting/host/remoting_me2me_host.cc View 7 chunks +9 lines, -10 lines 0 comments Download
M remoting/host/screen_recorder_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
A + remoting/host/session_event_executor_win.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + remoting/host/session_event_executor_win.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M remoting/host/simple_host_process.cc View 4 chunks +13 lines, -36 lines 0 comments Download
D remoting/host/win/session_desktop_environment_factory.h View 1 chunk +0 lines, -26 lines 0 comments Download
D remoting/host/win/session_desktop_environment_factory.cc View 1 chunk +0 lines, -38 lines 0 comments Download
D remoting/host/win/session_event_executor.h View 1 chunk +0 lines, -69 lines 0 comments Download
D remoting/host/win/session_event_executor.cc View 1 chunk +0 lines, -156 lines 0 comments Download
M remoting/protocol/protocol_mock_objects.h View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/protocol/protocol_mock_objects.cc View 1 chunk +3 lines, -1 line 0 comments Download
M remoting/remoting.gyp View 4 chunks +2 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
alexeypa (please no reviews)
8 years, 3 months ago (2012-09-09 04:04:02 UTC) #1
alexeypa (please no reviews)
8 years, 3 months ago (2012-09-09 04:05:21 UTC) #2
r155574 broke ClientSessionTest.ClamMouseEvents on Linux ASAN:
http://build.chromium.org/p/chromium.memory/buildstatus?builder=Linux%20ASAN%...

Powered by Google App Engine
This is Rietveld 408576698