Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2022)

Unified Diff: remoting/host/client_session.h

Issue 10909143: Revert 155574 - [Chromoting] Refactoring DesktopEnvironment and moving screen/audio recorders to Cl… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/host/chromoting_host_unittest.cc ('k') | remoting/host/client_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/client_session.h
===================================================================
--- remoting/host/client_session.h (revision 155615)
+++ remoting/host/client_session.h (working copy)
@@ -22,17 +22,8 @@
#include "remoting/protocol/input_stub.h"
#include "third_party/skia/include/core/SkPoint.h"
-namespace base {
-class SingleThreadTaskRunner;
-} // namespace base
-
namespace remoting {
-class AudioEncoder;
-class AudioScheduler;
-class DesktopEnvironment;
-class ScreenRecorder;
-class VideoEncoder;
class VideoFrameCapturer;
// A ClientSession keeps a reference to a connection to a client, and maintains
@@ -75,12 +66,12 @@
};
ClientSession(EventHandler* event_handler,
- scoped_refptr<base::SingleThreadTaskRunner> capture_task_runner,
- scoped_refptr<base::SingleThreadTaskRunner> encode_task_runner,
- scoped_refptr<base::SingleThreadTaskRunner> network_task_runner,
scoped_ptr<protocol::ConnectionToClient> connection,
- scoped_ptr<DesktopEnvironment> desktop_environment,
+ protocol::ClipboardStub* host_clipboard_stub,
+ protocol::InputStub* host_input_stub,
+ VideoFrameCapturer* capturer,
const base::TimeDelta& max_duration);
+ virtual ~ClientSession();
// protocol::HostStub interface.
virtual void NotifyClientDimensions(
@@ -103,23 +94,15 @@
const protocol::TransportRoute& route) OVERRIDE;
// Disconnects the session and destroys the transport. Event handler
- // is guaranteed not to be called after this method is called. The object
- // should not be used after this method returns.
+ // is guaranteed not to be called after this method is called. Can
+ // be called multiple times. The object should not be used after
+ // this method returns.
void Disconnect();
- // Stop all the session and deletes |this| once it is completely stopped.
- // StopAndDelete() is the only way to destoy a |ClientSession| instance.
- // |done_task| is executed when the session is completely stopped.
- void StopAndDelete(const base::Closure& done_task);
-
protocol::ConnectionToClient* connection() const {
return connection_.get();
}
- DesktopEnvironment* desktop_environment() const {
- return desktop_environment_.get();
- }
-
const std::string& client_jid() { return client_jid_; }
bool is_authenticated() { return auth_input_filter_.enabled(); }
@@ -133,30 +116,15 @@
// keys or mouse buttons pressed then these will be released.
void SetDisableInputs(bool disable_inputs);
- private:
- virtual ~ClientSession();
-
// Creates a proxy for sending clipboard events to the client.
scoped_ptr<protocol::ClipboardStub> CreateClipboardProxy();
- void OnRecorderStopped();
-
- // Creates an audio encoder for the specified configuration.
- static scoped_ptr<AudioEncoder> CreateAudioEncoder(
- const protocol::SessionConfig& config);
-
- // Creates a video encoder for the specified configuration.
- static VideoEncoder* CreateVideoEncoder(
- const protocol::SessionConfig& config);
-
+ private:
EventHandler* event_handler_;
// The connection to the client.
scoped_ptr<protocol::ConnectionToClient> connection_;
- // The desktop environment used by this session.
- scoped_ptr<DesktopEnvironment> desktop_environment_;
-
std::string client_jid_;
// The host clipboard and input stubs to which this object delegates.
@@ -191,6 +159,12 @@
// it.
base::WeakPtrFactory<protocol::ClipboardStub> client_clipboard_factory_;
+ // VideoFrameCapturer, used to determine current screen size for ensuring
+ // injected mouse events fall within the screen area.
+ // TODO(lambroslambrou): Move floor-control logic, and clamping to screen
+ // area, out of this class (crbug.com/96508).
+ VideoFrameCapturer* capturer_;
+
// The maximum duration of this session.
// There is no maximum if this value is <= 0.
base::TimeDelta max_duration_;
@@ -199,22 +173,6 @@
// is reached.
base::OneShotTimer<ClientSession> max_duration_timer_;
- scoped_refptr<base::SingleThreadTaskRunner> capture_task_runner_;
- scoped_refptr<base::SingleThreadTaskRunner> encode_task_runner_;
- scoped_refptr<base::SingleThreadTaskRunner> network_task_runner_;
-
- // Schedulers for audio and video capture.
- scoped_refptr<AudioScheduler> audio_scheduler_;
- scoped_refptr<ScreenRecorder> video_recorder_;
-
- // Number of screen recorders and audio schedulers that are currently being
- // used or shutdown. Used to delay shutdown if one or more
- // recorders/schedulers are asynchronously shutting down.
- int active_recorders_;
-
- // The task to be executed when the session is completely stopped.
- base::Closure done_task_;
-
DISALLOW_COPY_AND_ASSIGN(ClientSession);
};
« no previous file with comments | « remoting/host/chromoting_host_unittest.cc ('k') | remoting/host/client_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698