Improves application state persistance.

Simplifies sticky settings code. 
Now only file name (for save as PDF) and "AppState" are persisted. 
Persistence happens immediately when values change. 
AppState is a string generated by the print preview JS that contains data to persist. 
Also removes the print settings reset experiment flag.
Makes use of native layer changes in javascript.
Adds AppState object in javascript layer that manages persistance of print preview.
Fixes small bug where UMA stats for print preview destination search widget weren't getting recorded.

BUG=146476, 136926, 138625
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156432

[Albert Bodenhamer, 2012-09-07 20:09:36]

What happens if the previously used printer is not available?  I didn't see
any handling for that, but I may have missed it.


On Fri, Sep 7, 2012 at 12:18 PM, <rltoscano@google.com> wrote:

> Reviewers: Albert Bodenhamer,
>
> Description:
> Improves application state persistance.
>
> BUG=
>
>
> Please review this at
http://codereview.chromium.**org/10909124/<http://codereview.chromium.org/109...
>
> SVN Base:
http://git.chromium.org/**chromium/src.git@master<http://git.chromium.org/chr...
>
> Affected files:
>   A chrome/browser/resources/**print_preview/data/app_state.**js
>   M chrome/browser/resources/**print_preview/data/**destination_store.js
>   M chrome/browser/resources/**print_preview/native_layer.js
>   M chrome/browser/resources/**print_preview/print_preview.js
>   M chrome/browser/ui/webui/print_**preview/print_preview_handler.**cc
>
>
>


-- 
Albert Bodenhamer | Software Engineer | abodenha@chromium.<abodenha@google.com>
org

[Robert Toscano, 2012-09-07 20:11:55]

You can see in the AppState.init method. It will just have null for
selectedDestinationId. You can see that the destination store handles a
null initialDestinationId by selecting the first destination that gets
inserted in the destination store. This is the same behavior as previous to
this patch.


On Fri, Sep 7, 2012 at 1:09 PM, Albert Bodenhamer <abodenha@chromium.org>wrote:

> What happens if the previously used printer is not available?  I didn't
> see any handling for that, but I may have missed it.
>
>
> On Fri, Sep 7, 2012 at 12:18 PM, <rltoscano@google.com> wrote:
>
>> Reviewers: Albert Bodenhamer,
>>
>> Description:
>> Improves application state persistance.
>>
>> BUG=
>>
>>
>> Please review this at
http://codereview.chromium.**org/10909124/<http://codereview.chromium.org/109...
>>
>> SVN Base:
http://git.chromium.org/**chromium/src.git@master<http://git.chromium.org/chr...
>>
>> Affected files:
>>   A chrome/browser/resources/**print_preview/data/app_state.**js
>>   M chrome/browser/resources/**print_preview/data/**destination_store.js
>>   M chrome/browser/resources/**print_preview/native_layer.js
>>   M chrome/browser/resources/**print_preview/print_preview.js
>>   M chrome/browser/ui/webui/print_**preview/print_preview_handler.**cc
>>
>>
>>
>
>
> --
> Albert Bodenhamer | Software Engineer |
abodenha@chromium.<abodenha@google.com>
> org
>

[Robert Toscano, 2012-09-12 00:58:53]

Lei, can you approve chrome flag changes under chrome/common?

[Lei Zhang, 2012-09-12 01:01:08]

Always happy to lgtm flag removals in chrome/common.

[Albert Bodenhamer, 2012-09-12 17:33:05]

lgtm

[commit-bot: I haz the power, 2012-09-12 17:37:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rltoscano@google.com/10909124/6001

[commit-bot: I haz the power, 2012-09-12 17:37:43]

Failed to apply patch for
chrome/browser/ui/webui/print_preview/print_preview_handler.cc:
While running patch -p1 --forward --force;
patching file chrome/browser/ui/webui/print_preview/print_preview_handler.cc
Hunk #1 succeeded at 128 (offset -1 lines).
Hunk #2 succeeded at 236 (offset -1 lines).
Hunk #3 succeeded at 292 (offset -1 lines).
Hunk #4 succeeded at 416 (offset -1 lines).
Hunk #5 succeeded at 525 (offset -1 lines).
Hunk #6 succeeded at 674 (offset -1 lines).
Hunk #7 succeeded at 709 (offset -1 lines).
Hunk #8 succeeded at 726 (offset -1 lines).
Hunk #9 FAILED at 746.
Hunk #10 succeeded at 850 (offset -9 lines).
1 out of 10 hunks FAILED -- saving rejects to file
chrome/browser/ui/webui/print_preview/print_preview_handler.cc.rej

[commit-bot: I haz the power, 2012-09-12 17:42:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rltoscano@google.com/10909124/7019

[commit-bot: I haz the power, 2012-09-12 21:18:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rltoscano@google.com/10909124/11003

[commit-bot: I haz the power, 2012-09-13 00:06:24]

Change committed as 156432