Revert 154450 - Reliably install default apps into new installations.

Revert 154450 - Reliably install default apps into new installations.

r139107 changed the check to see if the profile that we're running it was
created by the current Chrome version. This does not appear to be true for the
default profile created during the first run (it doesn't have an explicit
profile.created_by_version preference, and the default value is 1.0.0), so
bring back the IsChromeFirstRun check (the profile version check is still kept
for additional profiles that are created).

BUG=145351
R=asargent@chromium.org
TEST=do a clean install of Chrome, the default profile should have the Gmail, YouTube and Search apps. Same for additional profiles that are created.

Review URL: https://chromiumcodereview.appspot.com/10916041

TBR=mihaip@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154452

[Mihai Parparita -not on Chrome, 2012-08-31 17:37:36]

LGTM

On Fri, Aug 31, 2012 at 10:22 AM, <jsbell@chromium.org> wrote:

> Reviewers: Mihai Parparita,
>
> Description:
> Revert 154450 - Reliably install default apps into new installations.
>
> r139107 changed the check to see if the profile that we're running it was
> created by the current Chrome version. This does not appear to be true for
> the
> default profile created during the first run (it doesn't have an explicit
> profile.created_by_version preference, and the default value is 1.0.0), so
> bring back the IsChromeFirstRun check (the profile version check is still
> kept
> for additional profiles that are created).
>
> BUG=145351
> R=asargent@chromium.org
> TEST=do a clean install of Chrome, the default profile should have the
> Gmail,
> YouTube and Search apps. Same for additional profiles that are created.
>
> Review URL:
https://chromiumcodereview.**appspot.com/10916041<https://chromiumcodereview....
>
> TBR=mihaip@chromium.org
>
> Please review this at
https://chromiumcodereview.**appspot.com/10909030/<https://chromiumcodereview...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src/<http://svn.chromium.org/chrome/trunk/src/>
>
> Affected files:
>   M     chrome/browser/extensions/**default_apps.cc
>
>
> Index: chrome/browser/extensions/**default_apps.cc
> ==============================**==============================**=======
> --- chrome/browser/extensions/**default_apps.cc   (revision 154451)
> +++ chrome/browser/extensions/**default_apps.cc   (working copy)
> @@ -75,14 +75,10 @@
>
>    switch (state) {
>      case kUnknown: {
> -      // Only new installations and profiles get default apps. In theory
> the
> -      // new profile checks should catch new installations, but that is
> not
> -      // always the case (http:/crbug.com/145351).
> +      // This is the first time the default apps feature runs on this
> profile.
> +      // Determine if we want to install them or not.
>        chrome::VersionInfo version_info;
> -      bool is_new_profile =
> -          profile_->**WasCreatedByVersionOrLater(**
> version_info.Version().c_str()**);
> -      bool is_first_run = first_run::IsChromeFirstRun();
> -      if (!is_first_run && !is_new_profile)
> +      if (!profile_->**WasCreatedByVersionOrLater(**
> version_info.Version().c_str()**))
>          install_apps = false;
>        break;
>      }
>
>
>