Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 10916041: Reliably install default apps into new installations. (Closed)

Created:
8 years, 3 months ago by Mihai Parparita -not on Chrome
Modified:
8 years, 3 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, Gaurav
Visibility:
Public.

Description

Reliably install default apps into new installations. r139107 changed the check to see if the profile that we're running it was created by the current Chrome version. This does not appear to be true for the default profile created during the first run (it doesn't have an explicit profile.created_by_version preference, and the default value is 1.0.0), so bring back the IsChromeFirstRun check (the profile version check is still kept for additional profiles that are created). BUG=145351 R=asargent@chromium.org TEST=do a clean install of Chrome, the default profile should have the Gmail, YouTube and Search apps. Same for additional profiles that are created. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154450 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154532

Patch Set 1 #

Patch Set 2 : Fix Android build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M chrome/browser/extensions/default_apps.cc View 1 2 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mihai Parparita -not on Chrome
8 years, 3 months ago (2012-08-31 00:28:42 UTC) #1
asargent_no_longer_on_chrome
LGTM
8 years, 3 months ago (2012-08-31 16:09:29 UTC) #2
commit-bot: I haz the power
Change committed as 154450
8 years, 3 months ago (2012-08-31 17:12:49 UTC) #3
Mihai Parparita -not on Chrome
Now with fewer Android build breakages (since the CQ set of tryservers got bypassed, I ...
8 years, 3 months ago (2012-08-31 17:57:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihaip@chromium.org/10916041/6001
8 years, 3 months ago (2012-08-31 20:27:07 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-08-31 23:09:13 UTC) #6
Change committed as 154532

Powered by Google App Engine
This is Rietveld 408576698