Chromium Code Reviews
Help | Chromium Project | Sign in
(637)

Issue 10908195: Fix delta computation in DoDeferredInstanceOfKnownGlobal() for ARM. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 7 months ago by ulan
Modified:
1 year, 7 months ago
Reviewers:
Yang
CC:
v8-dev_googlegroups.com
Visibility:
Public.

Description

Fix delta computation in DoDeferredInstanceOfKnownGlobal() for ARM.

BUG=v8:2314
R=yangguo@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=12478

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Add assert #

Patch Set 3 : Remove comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Lint Patch
M src/arm/lithium-codegen-arm.cc View 1 1 chunk +7 lines, -1 line 0 comments 0 errors Download
M test/mjsunit/mjsunit.status View 1 2 1 chunk +1 line, -3 lines 0 comments ? errors Download
Trybot results:
Commit:

Messages

Total messages: 2
ulan
PTAL
1 year, 7 months ago #1
Yang
1 year, 7 months ago #2
LGTM with comment.

https://chromiumcodereview.appspot.com/10908195/diff/2001/src/arm/lithium-cod...
File src/arm/lithium-codegen-arm.cc (right):

https://chromiumcodereview.appspot.com/10908195/diff/2001/src/arm/lithium-cod...
src/arm/lithium-codegen-arm.cc:2483: if
(masm_->InstructionsGeneratedSince(&before_push_delta) != 2) {
Maybe add an assert that InstructionsGeneratedSince(&before_push_delta) == 1 in
this case.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1275:d14800f88434