Issue 10908195: Fix delta computation in DoDeferredInstanceOfKnownGlobal() for ARM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10908195: Fix delta computation in DoDeferredInstanceOfKnownGlobal() for ARM. (Closed)

Created:
8 years, 3 months ago by ulan

Modified:
8 years, 3 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix delta computation in DoDeferredInstanceOfKnownGlobal() for ARM. BUG=v8:2314 R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=12478

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Add assert #

Patch Set 3 : Remove comment #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	src/arm/lithium-codegen-arm.cc	View	1	1 chunk	+7 lines, -1 line	0 comments	Download
	M	test/mjsunit/mjsunit.status	View	1 2	1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Yang

8 years, 3 months ago (2012-09-11 10:54:50 UTC) #2

LGTM with comment.

https://chromiumcodereview.appspot.com/10908195/diff/2001/src/arm/lithium-cod...
File src/arm/lithium-codegen-arm.cc (right):

https://chromiumcodereview.appspot.com/10908195/diff/2001/src/arm/lithium-cod...
src/arm/lithium-codegen-arm.cc:2483: if
(masm_->InstructionsGeneratedSince(&before_push_delta) != 2) {
Maybe add an assert that InstructionsGeneratedSince(&before_push_delta) == 1 in
this case.

Expand Messages | Collapse Messages