Moved RunMonkeyTests out of android_commands.py

Moved RunMonkeyTests out of android_commands.py

(it did not fit)
- simplified calling structure.

R=frankf@chromium.org,bulach@chromium.org,klundberg@chromium.org
BUG=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=156511

[bulach, 2012-09-11 11:08:49]

lgtm, but please let frank take a look at at..

I also have one suggestion for further moving this snippet.

also, please coordinate with shashi on where to land this change and the
dependencies.. I don't think we're running these tests upstream yet, so prefer
to land downstream first where we have coverage.

http://codereview.chromium.org/10908188/diff/1/build/android/run_monkey_test.py
File build/android/run_monkey_test.py (right):

http://codereview.chromium.org/10908188/diff/1/build/android/run_monkey_test....
build/android/run_monkey_test.py:80: def RunMonkey(adb, options):
nit: if nothing else will use this, please make it a member of MonkeyTest, and
add a "_" prefix.. maybe also rename to "_LaunchDeviceMonkey", to separate from
the other Run methods we have..

http://codereview.chromium.org/10908188/diff/1/build/android/run_monkey_test....
build/android/run_monkey_test.py:92: extra_args: A string of other args to pass
to the command verbatim.
if this is becomes a method, please remove this Args: section and just use
self.adb and self.options directly...

[frankf, 2012-09-11 17:36:51]

http://codereview.chromium.org/10908188/diff/1/build/android/run_monkey_test.py
File build/android/run_monkey_test.py (right):

http://codereview.chromium.org/10908188/diff/1/build/android/run_monkey_test....
build/android/run_monkey_test.py:10: import random
not alphabetical. Please run gpylint.

http://codereview.chromium.org/10908188/diff/1/build/android/run_monkey_test....
build/android/run_monkey_test.py:80: def RunMonkey(adb, options):
I prefer to have explicit parameters with default arguments instead of bundling
everything into options. It's more transparent and also allows other modules to
import and use this method.

[Isaac (away), 2012-09-13 03:06:17]

https://chromiumcodereview.appspot.com/10908188/diff/1/build/android/run_monk...
File build/android/run_monkey_test.py (right):

https://chromiumcodereview.appspot.com/10908188/diff/1/build/android/run_monk...
build/android/run_monkey_test.py:80: def RunMonkey(adb, options):
On 2012/09/11 17:36:51, frankf wrote:
> I prefer to have explicit parameters with default arguments instead of
bundling
> everything into options. It's more transparent and also allows other modules
to
> import and use this method.

This style of defaults is consistent with the rest of our code base.  I'm not
sure what pylint says but gpylint complains about functions with default values.

https://chromiumcodereview.appspot.com/10908188/diff/1/build/android/run_monk...
build/android/run_monkey_test.py:80: def RunMonkey(adb, options):
On 2012/09/11 11:08:49, bulach wrote:
> nit: if nothing else will use this, please make it a member of MonkeyTest, and
> add a "_" prefix.. maybe also rename to "_LaunchDeviceMonkey", to separate
from
> the other Run methods we have..

Done.

https://chromiumcodereview.appspot.com/10908188/diff/1/build/android/run_monk...
build/android/run_monkey_test.py:92: extra_args: A string of other args to pass
to the command verbatim.
On 2012/09/11 11:08:49, bulach wrote:
> if this is becomes a method, please remove this Args: section and just use
> self.adb and self.options directly...

Done.

[commit-bot: I haz the power, 2012-09-13 03:48:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ilevy@chromium.org/10908188/6001

[commit-bot: I haz the power, 2012-09-13 07:47:45]

Change committed as 156511