Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 10908157: Integrate ChromeToMobile with GTK Action Box. (Closed)

Created:
8 years, 3 months ago by msw
Modified:
8 years, 3 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, beaudoin, Elliot Glaysher
Visibility:
Public.

Description

Integrate ChromeToMobile with GTK Action Box. Show the bubble anchored to the action box button widget on command. Update the command state with other LocationBarViewGtk updates. TODO(followup): Show the lit mobile icon during the bubble lifetime. BUG=102709, 145624 TEST=Chrome To Mobile works with GTK Action Box. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155806

Patch Set 1 : Integrate ChromeToMobile with GTK Action Box #

Patch Set 2 : Cleanup. #

Total comments: 2

Patch Set 3 : Remove extra TODOs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -29 lines) Patch
M chrome/browser/ui/gtk/chrome_to_mobile_bubble_gtk.h View 1 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/gtk/chrome_to_mobile_bubble_gtk.cc View 1 2 5 chunks +9 lines, -21 lines 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 1 3 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
msw
Hey Evan, please take a look; thanks! +cc Philippe and Elliot for FYI.
8 years, 3 months ago (2012-09-10 11:13:45 UTC) #1
Evan Stade
lgtm https://chromiumcodereview.appspot.com/10908157/diff/13001/chrome/browser/ui/gtk/chrome_to_mobile_bubble_gtk.cc File chrome/browser/ui/gtk/chrome_to_mobile_bubble_gtk.cc (right): https://chromiumcodereview.appspot.com/10908157/diff/13001/chrome/browser/ui/gtk/chrome_to_mobile_bubble_gtk.cc#newcode273 chrome/browser/ui/gtk/chrome_to_mobile_bubble_gtk.cc:273: // TODO(msw): Show the lit mobile device icon ...
8 years, 3 months ago (2012-09-10 17:10:56 UTC) #2
msw
Done, landing. Thanks! https://chromiumcodereview.appspot.com/10908157/diff/13001/chrome/browser/ui/gtk/chrome_to_mobile_bubble_gtk.cc File chrome/browser/ui/gtk/chrome_to_mobile_bubble_gtk.cc (right): https://chromiumcodereview.appspot.com/10908157/diff/13001/chrome/browser/ui/gtk/chrome_to_mobile_bubble_gtk.cc#newcode273 chrome/browser/ui/gtk/chrome_to_mobile_bubble_gtk.cc:273: // TODO(msw): Show the lit mobile ...
8 years, 3 months ago (2012-09-10 18:03:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/10908157/3013
8 years, 3 months ago (2012-09-10 18:04:04 UTC) #4
commit-bot: I haz the power
8 years, 3 months ago (2012-09-10 20:11:50 UTC) #5
Change committed as 155806

Powered by Google App Engine
This is Rietveld 408576698