Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Unified Diff: chrome/browser/ui/gtk/chrome_to_mobile_bubble_gtk.h

Issue 10908157: Integrate ChromeToMobile with GTK Action Box. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove extra TODOs. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/gtk/chrome_to_mobile_bubble_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/gtk/chrome_to_mobile_bubble_gtk.h
diff --git a/chrome/browser/ui/gtk/chrome_to_mobile_bubble_gtk.h b/chrome/browser/ui/gtk/chrome_to_mobile_bubble_gtk.h
index c4600e5043768e67c07ec54b495e360ee180cf61..c70856398c6b80564696d88da028af342d790090 100644
--- a/chrome/browser/ui/gtk/chrome_to_mobile_bubble_gtk.h
+++ b/chrome/browser/ui/gtk/chrome_to_mobile_bubble_gtk.h
@@ -44,8 +44,8 @@ class ChromeToMobileBubbleGtk : public BubbleDelegateGtk,
public ChromeToMobileService::Observer {
public:
// Shows the Chrome to Mobile bubble, pointing at |anchor_widget|.
- // |anchor_image| is updated to show the lit icon during the bubble lifetime.
- static void Show(GtkImage* anchor_image, Browser* browser);
+ // TODO(msw): Show the lit mobile icon during the bubble lifetime.
+ static void Show(GtkWidget* anchor_widget, Browser* browser);
// BubbleDelegateGtk:
virtual void BubbleClosing(BubbleGtk* bubble, bool closed_by_escape) OVERRIDE;
@@ -63,7 +63,7 @@ class ChromeToMobileBubbleGtk : public BubbleDelegateGtk,
virtual void OnSendComplete(bool success) OVERRIDE;
private:
- ChromeToMobileBubbleGtk(GtkImage* anchor_image, Browser* browser);
+ ChromeToMobileBubbleGtk(GtkWidget* anchor_widget, Browser* browser);
virtual ~ChromeToMobileBubbleGtk();
// Notified when |content_| is destroyed so we can delete our instance.
@@ -90,8 +90,8 @@ class ChromeToMobileBubbleGtk : public BubbleDelegateGtk,
// The list of radio buttons corresponding to the list of mobile devices.
std::vector<GtkWidget*> radio_buttons_;
- // The anchor image, updated to show the lit icon during the bubble lifetime.
- GtkImage* anchor_image_;
+ // The widget to which this bubble is anchored.
+ GtkWidget* anchor_widget_;
// The labels in the bubble; tracked for theme changes.
std::vector<GtkWidget*> labels_;
« no previous file with comments | « no previous file | chrome/browser/ui/gtk/chrome_to_mobile_bubble_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698