Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10908153: [Panel refactor] Deprecate old panels. (Closed)

Created:
8 years, 3 months ago by jennb
Modified:
8 years, 3 months ago
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, yoshiki+watch_chromium.org, dcheng, Aaron Boodman, jennb, jianli, tfarina
Visibility:
Public.

Description

[Panel refactor] Deprecate old panels. Deleted: - old panels tests - logic related to old BrowserWindow Panels - legacy API for old panels - "scaffolding" added to keep old panels functional during refactor BUG=127323 TEST=Tests for old panels removed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=155930

Patch Set 1 : #

Patch Set 2 : Synced #

Patch Set 3 : fix linux compile #

Patch Set 4 : fix views compile, no need to delete extra mac menu items cuz not using browser command updater any… #

Total comments: 1

Patch Set 5 : Synced #

Patch Set 6 : fix linux_chromeos test failure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -10274 lines) Patch
M chrome/browser/extensions/api/tabs/tabs.cc View 1 2 3 4 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/window_open_apitest.cc View 1 2 3 4 5 4 chunks +8 lines, -13 lines 0 comments Download
M chrome/browser/task_manager/task_manager_browsertest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/task_manager/task_manager_resource_providers.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 3 4 5 chunks +3 lines, -25 lines 0 comments Download
M chrome/browser/ui/browser_navigator.cc View 1 2 3 4 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/ui/browser_navigator_browsertest.cc View 1 chunk +0 lines, -56 lines 0 comments Download
M chrome/browser/ui/panels/base_panel_browser_test.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/panels/base_panel_browser_test.cc View 1 5 chunks +1 line, -13 lines 0 comments Download
M chrome/browser/ui/panels/detached_panel_strip.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/docked_panel_strip.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/docked_panel_strip.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/native_panel.h View 5 chunks +3 lines, -28 lines 0 comments Download
D chrome/browser/ui/panels/native_panel_cocoa.h View 1 chunk +0 lines, -25 lines 0 comments Download
D chrome/browser/ui/panels/old_base_panel_browser_test.h View 1 chunk +0 lines, -124 lines 0 comments Download
D chrome/browser/ui/panels/old_base_panel_browser_test.cc View 1 1 chunk +0 lines, -504 lines 0 comments Download
D chrome/browser/ui/panels/old_detached_panel_browsertest.cc View 1 2 3 4 1 chunk +0 lines, -161 lines 0 comments Download
D chrome/browser/ui/panels/old_docked_panel_browsertest.cc View 1 chunk +0 lines, -280 lines 0 comments Download
D chrome/browser/ui/panels/old_panel.h View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/ui/panels/old_panel.cc View 1 chunk +0 lines, -69 lines 0 comments Download
D chrome/browser/ui/panels/old_panel_and_desktop_notification_browsertest.cc View 1 chunk +0 lines, -417 lines 0 comments Download
D chrome/browser/ui/panels/old_panel_browsertest.cc View 1 2 3 4 1 chunk +0 lines, -1526 lines 0 comments Download
D chrome/browser/ui/panels/old_panel_drag_browsertest.cc View 1 chunk +0 lines, -1347 lines 0 comments Download
D chrome/browser/ui/panels/old_panel_resize_browsertest.cc View 1 chunk +0 lines, -414 lines 0 comments Download
M chrome/browser/ui/panels/panel.h View 9 chunks +11 lines, -26 lines 0 comments Download
M chrome/browser/ui/panels/panel.cc View 4 chunks +2 lines, -29 lines 0 comments Download
D chrome/browser/ui/panels/panel_browser_frame_view.h View 1 chunk +0 lines, -147 lines 0 comments Download
D chrome/browser/ui/panels/panel_browser_frame_view.cc View 1 chunk +0 lines, -812 lines 0 comments Download
D chrome/browser/ui/panels/panel_browser_titlebar_gtk.h View 1 chunk +0 lines, -120 lines 0 comments Download
D chrome/browser/ui/panels/panel_browser_titlebar_gtk.cc View 1 chunk +0 lines, -360 lines 0 comments Download
D chrome/browser/ui/panels/panel_browser_view.h View 1 chunk +0 lines, -203 lines 0 comments Download
D chrome/browser/ui/panels/panel_browser_view.cc View 1 chunk +0 lines, -705 lines 0 comments Download
D chrome/browser/ui/panels/panel_browser_window.h View 1 chunk +0 lines, -175 lines 0 comments Download
D chrome/browser/ui/panels/panel_browser_window.cc View 1 chunk +0 lines, -482 lines 0 comments Download
D chrome/browser/ui/panels/panel_browser_window_cocoa.h View 1 chunk +0 lines, -131 lines 0 comments Download
D chrome/browser/ui/panels/panel_browser_window_cocoa.mm View 1 chunk +0 lines, -455 lines 0 comments Download
D chrome/browser/ui/panels/panel_browser_window_cocoa_unittest.mm View 1 chunk +0 lines, -419 lines 0 comments Download
D chrome/browser/ui/panels/panel_browser_window_gtk.h View 1 chunk +0 lines, -152 lines 0 comments Download
D chrome/browser/ui/panels/panel_browser_window_gtk.cc View 1 chunk +0 lines, -705 lines 0 comments Download
M chrome/browser/ui/panels/panel_browsertest.cc View 3 chunks +1 line, -14 lines 0 comments Download
M chrome/browser/ui/panels/panel_cocoa.h View 4 chunks +4 lines, -13 lines 0 comments Download
M chrome/browser/ui/panels/panel_cocoa.mm View 3 chunks +0 lines, -20 lines 0 comments Download
M chrome/browser/ui/panels/panel_drag_gtk.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_gtk.h View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/panels/panel_gtk.cc View 6 chunks +2 lines, -21 lines 0 comments Download
M chrome/browser/ui/panels/panel_host.cc View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_manager.h View 5 chunks +0 lines, -20 lines 0 comments Download
M chrome/browser/ui/panels/panel_manager.cc View 5 chunks +2 lines, -49 lines 0 comments Download
M chrome/browser/ui/panels/panel_mouse_watcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/panels/panel_view.h View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/panels/panel_view.cc View 3 chunks +0 lines, -20 lines 0 comments Download
M chrome/browser/ui/panels/panel_window_controller_cocoa.h View 5 chunks +4 lines, -16 lines 0 comments Download
M chrome/browser/ui/panels/panel_window_controller_cocoa.mm View 1 2 3 6 chunks +29 lines, -37 lines 0 comments Download
M chrome/browser/ui/tab_contents/tab_contents.h View 1 2 3 4 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_factory_aura.cc View 1 2 3 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_factory_win.cc View 1 2 3 2 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_factory_x11.cc View 1 2 3 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 4 chunks +0 lines, -15 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 4 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jennb
Finally ready to delete all the BrowserWindow Panel code! Large patch, but mostly deletes. Jenn
8 years, 3 months ago (2012-09-07 23:45:33 UTC) #1
tfarina
Thanks for doing this! http://codereview.chromium.org/10908153/diff/4064/chrome/browser/ui/panels/panel_browser_frame_view.h File chrome/browser/ui/panels/panel_browser_frame_view.h (left): http://codereview.chromium.org/10908153/diff/4064/chrome/browser/ui/panels/panel_browser_frame_view.h#oldcode11 chrome/browser/ui/panels/panel_browser_frame_view.h:11: #include "chrome/browser/ui/views/frame/browser_non_client_frame_view.h" go, go, go ...
8 years, 3 months ago (2012-09-08 01:53:40 UTC) #2
Ben Goodger (Google)
Very cool! LGTM
8 years, 3 months ago (2012-09-10 15:29:54 UTC) #3
Dmitry Titov
LGTM, yay!
8 years, 3 months ago (2012-09-10 20:19:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennb@chromium.org/10908153/11075
8 years, 3 months ago (2012-09-10 20:21:52 UTC) #5
commit-bot: I haz the power
Try job failure for 10908153-11075 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 3 months ago (2012-09-10 23:03:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennb@chromium.org/10908153/11075
8 years, 3 months ago (2012-09-11 01:02:53 UTC) #7
commit-bot: I haz the power
8 years, 3 months ago (2012-09-11 02:58:22 UTC) #8 
Change committed as 155930

Powered by Google App Engine
This is Rietveld 408576698