Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4441)

Unified Diff: chrome/browser/ui/panels/panel_gtk.cc

Issue 10908153: [Panel refactor] Deprecate old panels. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix linux_chromeos test failure Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/panels/panel_gtk.h ('k') | chrome/browser/ui/panels/panel_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/panels/panel_gtk.cc
diff --git a/chrome/browser/ui/panels/panel_gtk.cc b/chrome/browser/ui/panels/panel_gtk.cc
index 5b73917d20faf9b3e663a6b7c2b10489d23c94c3..b7455e4e507799d2eb6677772cbc865f19586d6d 100644
--- a/chrome/browser/ui/panels/panel_gtk.cc
+++ b/chrome/browser/ui/panels/panel_gtk.cc
@@ -264,7 +264,7 @@ void PanelGtk::Init() {
// TODO(jennb): add GlobalMenuBar after refactoring out Browser.
- // The window container draws the custom browser frame.
+ // The window container draws the custom window frame.
window_container_ = gtk_alignment_new(0.0, 0.0, 1.0, 1.0);
gtk_widget_set_name(window_container_, "chrome-custom-frame-border");
gtk_widget_set_app_paintable(window_container_, TRUE);
@@ -673,7 +673,7 @@ gboolean PanelGtk::OnButtonPressEvent(GtkWidget* widget,
}
void PanelGtk::ActiveWindowChanged(GdkWindow* active_window) {
- // Do nothing if we're in the process of closing the browser window.
+ // Do nothing if we're in the process of closing the panel window.
if (!window_)
return;
@@ -856,10 +856,6 @@ void PanelGtk::LoadingAnimationCallback() {
titlebar_->UpdateThrobber(panel_->GetWebContents());
}
-FindBar* PanelGtk::CreatePanelFindBar() {
- return NULL; // legacy
-}
-
void PanelGtk::NotifyPanelOnUserChangedTheme() {
titlebar_->UpdateTextColor();
InvalidateWindow();
@@ -898,13 +894,6 @@ bool PanelGtk::IsDrawingAttention() const {
return is_drawing_attention_;
}
-bool PanelGtk::PreHandlePanelKeyboardEvent(
- const NativeWebKeyboardEvent& event,
- bool* is_keyboard_shortcut) {
- // No need to prehandle as no keys are reserved.
- return false;
-}
-
void PanelGtk::HandlePanelKeyboardEvent(
const NativeWebKeyboardEvent& event) {
GdkEventKey* os_event = &event.os_event->key;
@@ -943,10 +932,6 @@ void PanelGtk::DetachWebContents(content::WebContents* contents) {
}
}
-Browser* PanelGtk::GetPanelBrowser() const {
- return NULL; // legacy
-}
-
gfx::Size PanelGtk::WindowSizeFromContentSize(
const gfx::Size& content_size) const {
gfx::Size& frame_size = GetFrameSize();
@@ -967,10 +952,6 @@ int PanelGtk::TitleOnlyHeight() const {
return allocation.height;
}
-void PanelGtk::EnsurePanelFullyVisible() {
- gtk_window_present(window_);
-}
-
void PanelGtk::SetPanelAlwaysOnTop(bool on_top) {
gtk_window_set_keep_above(window_, on_top);
« no previous file with comments | « chrome/browser/ui/panels/panel_gtk.h ('k') | chrome/browser/ui/panels/panel_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698