Issue 10908096: webui: Request favicons at all required display scale factors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10908096: webui: Request favicons at all required display scale factors (Closed)

Created:
8 years, 3 months ago by Nico

Modified:
8 years, 3 months ago

Reviewers:
pkotwicz

CC:
chromium-reviews, asanka, arv (Not doing code reviews), Randy Smith (Not in Mondays), sky

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

webui: Request favicons at all required display scale factors Note: This doesn't help for webui pages that set the favicon to a lodpi png using <link rel=icon>. The options page does this to switch the favicon for different views. For this reaosn, remove an uneeded link rel=icon from the downloads page. BUG=145228 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=154991

Patch Set 1 #

Patch Set 2 : . #

Created: 8 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -14 lines)			Patch
M	chrome/browser/favicon/favicon_service.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/resources/downloads/downloads.html	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/chrome_web_ui_controller_factory.h	View		1 chunk	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc	View	1	2 chunks	+11 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

8 years, 3 months ago (2012-09-05 17:16:57 UTC) #3

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/10908096/3001

Expand Messages | Collapse Messages