Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7007)

Unified Diff: chrome/browser/favicon/favicon_service.cc

Issue 10908096: webui: Request favicons at all required display scale factors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/downloads/downloads.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/favicon/favicon_service.cc
diff --git a/chrome/browser/favicon/favicon_service.cc b/chrome/browser/favicon/favicon_service.cc
index ad4a79dfbd1672fc657b7b593a2010a763161e06..b1f50874d601ae54aba44d1dcc92d38111b8caf0 100644
--- a/chrome/browser/favicon/favicon_service.cc
+++ b/chrome/browser/favicon/favicon_service.cc
@@ -211,9 +211,8 @@ FaviconService::Handle FaviconService::GetFaviconForURLImpl(
FaviconService::Handle handle = request->handle();
if (page_url.SchemeIs(chrome::kChromeUIScheme) ||
page_url.SchemeIs(chrome::kExtensionScheme)) {
- // TODO(pkotwicz): Pass in desired size and desired scale factors.
ChromeWebUIControllerFactory::GetInstance()->GetFaviconForURL(
- profile, request, page_url);
+ profile, request, page_url, desired_scale_factors);
} else {
// TODO(pkotwicz): Pass in desired size and desired scale factors.
if (history_service_)
« no previous file with comments | « no previous file | chrome/browser/resources/downloads/downloads.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698