Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 10908063: Fix apply_issue.py to work on python 2.6. (Closed)

Created:
8 years, 3 months ago by M-A Ruel
Modified:
8 years, 3 months ago
CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel
Visibility:
Public.

Description

Fix apply_issue.py to work on python 2.6 with anonymous request. Fix RawCheckout support in apply_issue.py. TBR=rogerta@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=154703

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M apply_issue.py View 2 chunks +6 lines, -3 lines 1 comment Download
M rietveld.py View 1 chunk +4 lines, -0 lines 3 comments Download
M third_party/upload.py View 1 chunk +5 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
https://chromiumcodereview.appspot.com/10908063/diff/1/apply_issue.py File apply_issue.py (right): https://chromiumcodereview.appspot.com/10908063/diff/1/apply_issue.py#newcode64 apply_issue.py:64: print >> sys.stderr, 'Accessing the issue requires login.' Hopefully, ...
8 years, 3 months ago (2012-09-03 17:34:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10908063/1
8 years, 3 months ago (2012-09-03 17:34:35 UTC) #2
commit-bot: I haz the power
Change committed as 154703
8 years, 3 months ago (2012-09-03 17:37:19 UTC) #3
Roger Tawa OOO till Jul 10th
lgtm https://chromiumcodereview.appspot.com/10908063/diff/1/rietveld.py File rietveld.py (right): https://chromiumcodereview.appspot.com/10908063/diff/1/rietveld.py#newcode55 rietveld.py:55: self.rpc_server.authenticated = True On 2012/09/03 17:34:25, Marc-Antoine Ruel ...
8 years, 3 months ago (2012-09-04 13:48:31 UTC) #4
M-A Ruel
8 years, 3 months ago (2012-09-04 17:36:29 UTC) #5
https://chromiumcodereview.appspot.com/10908063/diff/1/rietveld.py
File rietveld.py (right):

https://chromiumcodereview.appspot.com/10908063/diff/1/rietveld.py#newcode55
rietveld.py:55: self.rpc_server.authenticated = True
On 2012/09/04 13:48:31, Roger Tawa wrote:
> On 2012/09/03 17:34:25, Marc-Antoine Ruel wrote:
> > My fault in removing it in r154696.
> 
> :-)  I thought you had figured out a better way to handle it when you removed
> the setting of authenticated.  Since you are putting it back though, not sure
> you need still the lambda function.

No, it still did prompts without it. :/

Powered by Google App Engine
This is Rietveld 408576698